feat: add missing translations for bookmarks and loading states#10
Merged
Conversation
…sages - Added 7 new translation keys to all 10 language files: - no_messages, last_message_media - bookmarks_import_button, bookmarks_export_button - bookmarks_import_error, bookmarks_imported_message, bookmarks_skipped_message - Updated BookmarksPanel.svelte: - Replaced Import/Export button hardcoded text with translations - Updated import success/error messages to use translation functions - Replaced action button labels (Go to, Edit, Delete) with translation calls - Updated ChatList.svelte: - Loading stage labels now use translations (loading_reading, loading_extracting, loading_parsing) - Message/media count labels use translation functions - Last message display uses no_messages and last_message_media translations - Transcription Language label translated - Updated BookmarkButton.svelte: - Added translation import - Title and aria-label attributes now use bookmarks_add/bookmarks_edit translations - All hardcoded UI strings in bookmarks and chat loading now properly translated across all 10 languages
- Added stats_failed translation key to all 10 language files for statistics error handling - Updated ChatStats.svelte to use m.stats_failed() instead of hardcoded 'Failed to compute statistics' - Updated SearchBar.svelte to use m.search_placeholder() for default placeholder instead of hardcoded 'Search messages...' - Ensures complete i18n coverage across all components
github-actions Bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
# [1.7.0](v1.6.0...v1.7.0) (2025-12-10) ### Features * add missing translations for bookmarks and loading states ([#10](#10)) ([4c5db28](4c5db28))
Contributor
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
rodrigogs
added a commit
that referenced
this pull request
Apr 1, 2026
Correctness: - #1: handleRemoveChat now removes from UI first (sync), cleans up IndexedDB in background to avoid stale index issues - #2: Remove redundant double-store of FileSystemFileHandle (savePersistedChat already handles it) - #3: Restored chats now populate chatFileReferences with persistedId to prevent orphaned duplicates on toggle Security: - #4: Use file descriptor with O_NOFOLLOW to prevent TOCTOU race in Electron file read IPC DRY: - #5: Extract LoadingChat interface to shared state.svelte.ts - #6: getBookmarksForChatAsExport delegates to getBookmarksForChat - #7: Extract sanitizeFilename helper to format.ts - #8: formatDate kept local (locale-aware, not extractable) - #9: Add addRemembered/removeRemembered helpers (5 call sites) i18n/Accessibility: - #10: Add aria-label to ReselectFileModal drop zone - #11: i18n Modal close label across 10 locales Clean Code: - #12: Split handleToggleRemember into rememberChat/forgetChat - #13: Toast uses Icon component instead of inline SVGs
rodrigogs
added a commit
that referenced
this pull request
Apr 1, 2026
Correctness: - #1: handleRemoveChat now removes from UI first (sync), cleans up IndexedDB in background to avoid stale index issues - #2: Remove redundant double-store of FileSystemFileHandle (savePersistedChat already handles it) - #3: Restored chats now populate chatFileReferences with persistedId to prevent orphaned duplicates on toggle Security: - #4: Use file descriptor with O_NOFOLLOW to prevent TOCTOU race in Electron file read IPC DRY: - #5: Extract LoadingChat interface to shared state.svelte.ts - #6: getBookmarksForChatAsExport delegates to getBookmarksForChat - #7: Extract sanitizeFilename helper to format.ts - #8: formatDate kept local (locale-aware, not extractable) - #9: Add addRemembered/removeRemembered helpers (5 call sites) i18n/Accessibility: - #10: Add aria-label to ReselectFileModal drop zone - #11: i18n Modal close label across 10 locales Clean Code: - #12: Split handleToggleRemember into rememberChat/forgetChat - #13: Toast uses Icon component instead of inline SVGs
rodrigogs
added a commit
that referenced
this pull request
Apr 1, 2026
…storation (#66) * feat: add persistent conversation feature with cross-platform file restoration Implement "Remember Conversation" toggle that persists chat sessions across app restarts using IndexedDB (idb-keyval). Three platform strategies: Electron file paths, Chromium FileSystemFileHandle, and fallback reselect for Firefox/Safari. New components: RestoreSessionModal, ReselectFileModal, Toast, Modal. Stores metadata, bookmarks, transcriptions, settings (~1MB). Never stores the ZIP file itself. * fix: resolve all 15 type errors in persistent conversations feature - Add File System Access API type declarations (FileSystemHandlePermissionDescriptor, OpenFilePickerOptions, FileSystemFileHandle augmentation, Window.showOpenFilePicker) to the global scope in src/app.d.ts - Register 7 missing icon names (alert-circle, folder, clock, check-all, x, check-circle, message-circle) in the Icon component with SVG path definitions - Add missing isElectronPathReference import in +page.svelte, which also resolves the union type narrowing error for filePath access * fix(electron): harden file:readFromPath IPC handler - Restrict to .zip files only to prevent path traversal attacks - Use async fs.promises.readFile() instead of blocking readFileSync() - Properly slice Buffer to ArrayBuffer using byteOffset/byteLength * fix(i18n): replace hardcoded English strings with Paraglide messages Replace hardcoded strings in RestoreSessionModal ("Select All", "Deselect All") and ReselectFileModal ("Drop WhatsApp ZIP file here", "or click below to browse", "Browse Files") with proper Paraglide i18n message calls. Added translations for all 10 supported languages. * fix(persistence): clean up IndexedDB entries when removing a remembered chat When a user removed a chat via handleRemoveChat(), persisted data in IndexedDB was not cleaned up, leaving orphaned entries that caused the restore modal to show stale chats. Now handleRemoveChat checks if the chat is in rememberedChats and, if so, finds and removes the persisted entry from IndexedDB before removing it from UI state. * fix(persistence): add error logging to silent catch blocks Add console.error/warn logging to five catch blocks in persistence.svelte.ts that were silently swallowing errors, making IndexedDB issues impossible to debug. * fix(ReselectFileModal): eliminate drag-drop flicker with counter pattern Replace boolean isDragging state with dragCounter pattern to fix visual flicker that occurred when dragging files over nested elements. The counter increments on dragenter and decrements on dragleave, preventing the rapid toggling that caused the flicker. * chore: remove AI handoff document * fix: clean up dead code, timer leaks, and unused imports * fix: resolve critical bugs and extract duplicated parse/index logic - Fix C2: restore loop now awaits user reselect via Promise pattern instead of continuing to next chat immediately - Fix C1: add one-time guard to $effect for persistence check - Fix C3: harden Electron file read with path normalization and symlink protection (lstat check) - DRY: extract startIndexWorker() and makeProgressCallback() from ~150 lines of duplicated code between handleFilesSelected and loadChatFromBuffer * fix: address final review items - Replace remaining hardcoded English strings with i18n messages - Filter transcriptions to only include current chat's message IDs when persisting (prevents cross-chat data leakage) - Add translations for new keys to all 9 non-English locales - Document chatFileReferences intentional non-reactive mutation * fix: translate all persistence keys and remove dead isRestoring state * refactor: deduplicate getBookmarksForChatAsExport * fix(electron): use file descriptor to prevent TOCTOU race in file read * refactor(Toast): replace inline SVGs with Icon component Replace inline SVG elements with the reusable Icon component for better code maintainability and consistency. The status icon now uses check-circle for success and alert-circle for error/info types, while the close button uses the x icon. * fix(a11y): add aria-label to drop zone and i18n Modal close label - Add aria-label to drop zone in ReselectFileModal for screen reader accessibility - Replace hardcoded 'Close modal' string with i18n key close_modal in Modal component - Add close_modal translations to all 10 locale files (en, pt, es, fr, de, it, nl, ja, zh, ru) * refactor: address all 13 review items Correctness: - #1: handleRemoveChat now removes from UI first (sync), cleans up IndexedDB in background to avoid stale index issues - #2: Remove redundant double-store of FileSystemFileHandle (savePersistedChat already handles it) - #3: Restored chats now populate chatFileReferences with persistedId to prevent orphaned duplicates on toggle Security: - #4: Use file descriptor with O_NOFOLLOW to prevent TOCTOU race in Electron file read IPC DRY: - #5: Extract LoadingChat interface to shared state.svelte.ts - #6: getBookmarksForChatAsExport delegates to getBookmarksForChat - #7: Extract sanitizeFilename helper to format.ts - #8: formatDate kept local (locale-aware, not extractable) - #9: Add addRemembered/removeRemembered helpers (5 call sites) i18n/Accessibility: - #10: Add aria-label to ReselectFileModal drop zone - #11: i18n Modal close label across 10 locales Clean Code: - #12: Split handleToggleRemember into rememberChat/forgetChat - #13: Toast uses Icon component instead of inline SVGs * fix: address all 9 Copilot review comments 1. Capture Electron file.path from drag-drop for persistence 2. Block metadata restoration when file validation fails 3. Deduplicate savePersistedChat (removes existing entry first) 4. Filter transcriptions by chat message IDs (prevents cross-chat leak) 5. Case-insensitive .zip check in ReselectFileModal 6. Clamp dragCounter to 0 minimum 7. Use isAbsolute + reject .. segments for Electron path validation 8. Guard error.message with instanceof Error check 9. Add keyboard/click handlers to drop zone for accessibility * fix: address 3 new Copilot review comments - Seed rememberedChats from IndexedDB on load so toggle state is correct even when user skips restore modal or clicks Start Fresh - Fix verifyHandlePermission docstring to reflect shouldRequest param - Use chatId+messageId composite key for bookmark import dedup to prevent cross-chat bookmark collisions * fix: capture FileSystemFileHandle during drag-drop for seamless persistence - Use DataTransferItem.getAsFileSystemHandle() during drop event to capture handles without showing a second file picker (Chrome 86+) - Remove promptForFileHandle() call from rememberChat — handles are now captured at drag-drop time, eliminating the confusing double- file-picker UX - Update reselect flow to capture Electron file.path and update the persisted entry so future restores work automatically - Add DataTransferItem.getAsFileSystemHandle type declaration * fix: capture file handles synchronously during drop and fix closure bug - Start all getAsFileSystemHandle() Promises synchronously via Promise.all before any await, preventing DataTransferItem invalidation after first async tick - Capture handleIndex and file path BEFORE the async IIFE to avoid closure-over-loop-variable bug where stale index was read after multiple awaits * fix: pass Electron file path from dialog to persistence layer The Electron file picker (openFile dialog) returns the absolute path but it was discarded when creating the File object from the buffer. This caused all Electron-picked files to be stored as 'reselect-required' instead of 'electron-path', forcing manual reselection on every restore. Now FileDropZone passes the path from Electron's dialog result via a new 'paths' callback parameter. handleFilesSelected prefers this explicit path over file.path (drag-drop fallback). * debug: add persistence flow logging to trace Electron path issue * fix: address 4 Copilot review comments - Toast: reset visibility and restart timer when message prop changes - FileDropZone: use showOpenFilePicker() on Chrome for file input to capture FileSystemFileHandle (drag-drop already captures handles; this fixes the regular "click to browse" flow) - Remove unused isFileSystemAccessSupported import from +page.svelte - Electron dialog path already fixed (result.path passed via paths callback parameter) * fix: address 3 Copilot review comments - Electron IPC: add lstat pre-check for cross-platform symlink rejection (O_NOFOLLOW not supported on Windows), with graceful fallback to O_RDONLY when O_NOFOLLOW unavailable - FileDropZone: enable multi-select in showOpenFilePicker to match the existing <input multiple> behavior - CSS: use :where(button) for low-specificity cursor rule so Tailwind utilities can override it * fix: ReselectFileModal uses Electron dialog to capture file path The reselect modal was using the web file input which doesn't capture the absolute file path in Electron. Now uses the Electron native dialog (electronAPI.openFile) which returns the path, and passes it through to updatePersistedChat so the entry is upgraded from 'reselect-required' to 'electron-path'. After one reselect, future restores work automatically. * fix: move Remember Conversation above Transcription Language in context menu * fix: ReselectFileModal captures FileSystemFileHandle on Chrome and upgrades persisted entries The reselect modal was using plain <input type=file> on Chrome, which doesn't capture a FileSystemFileHandle. This meant even after reselecting, the entry stayed as 'reselect-required' and the user would be prompted again on every restart. Now: - Chrome/Edge: uses showOpenFilePicker() to capture a handle, then upgrades the persisted entry from 'reselect-required' to 'file-handle' via storeFileHandle + updatePersistedChat - Electron: uses native dialog to capture path, upgrades to 'electron-path' - Drag-drop in reselect modal also captures handle via getAsFileSystemHandle() After one reselect, future restores work automatically on all platforms. * fix: removing chat from list no longer deletes persisted data Removing a chat only clears it from the current session. Persisted data in IndexedDB is preserved so the chat reappears in the restore modal on next launch. To permanently forget a chat, user must toggle Remember Conversation off. * chore: remove debug logging from persistence flow * fix: sidebar import uses Electron dialog and captures file path The sidebar "Import chat" button was using a plain <input type=file> which doesn't reliably provide file.path in Electron. Now uses the same platform-aware import as the main drop zone: - Electron: native dialog via electronAPI.openFile() with path capture - Chrome/Edge: showOpenFilePicker() with handle capture - Fallback: regular file input Also fixes Node.js Buffer pool issue in dialog:openFile handler (was sending entire shared ArrayBuffer instead of just the file's portion). * refactor: address all review items - dead code, DRY, a11y, error feedback - Replace dynamic import of storeFileHandle with static import - Remove 6 unused i18n keys from all 10 locale files - Remove dead exports: promptForFileHandle, getPersistedChat, getBookmarksForChatAsExport - Add error toast on restore failure in handleRestoreChats - Extract shared file-picker helpers (openZipFilePicker, openElectronFile, getElectronFilePath) - Add aria-label to FileDropZone drop zone - Rename persistence_close_notification to close_notification in Toast * refactor: centralize modals, fix cross-chat ID collisions, address review feedback - Extract ChatAvatar component replacing 3 inline avatar implementations - Add shared formatRelativeDate helper (label/compact modes) - Add Button size="lg" variant with disabled styles - Vertically center Modal on all breakpoints, not just desktop - RestoreSessionModal: remove description banner, only chat list scrolls, fixed footer with action buttons - Fix message ID collisions across chats by including filename in hash - Fix Toast timer not restarting when message changes while visible - Gate reselect flow: only upgrade persisted entry when validation passes - Add persistence_restore_failed i18n key across all 10 locales - Remove unused isFileSystemAccessSupported import and function --------- Co-authored-by: Rodrigo Gomes da Silva <rodrigo.smscom@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds comprehensive i18n coverage for previously untranslated UI strings across the application.
New Translation Keys Added (7 keys × 10 languages = 70 translations)
no_messages- "No messages" label in chat listlast_message_media- "📎 Media" label for media messages previewbookmarks_import_button- Import button label in bookmarks panelbookmarks_export_button- Export button label in bookmarks panelbookmarks_import_error- Error message when bookmark import failsbookmarks_imported_message- Success message showing imported bookmark countbookmarks_skipped_message- Additional info about skipped duplicate bookmarksComponents Updated
BookmarksPanel.svelte:
ChatList.svelte:
BookmarkButton.svelte:
Languages Supported
All 10 supported languages updated:
Testing
Closes #[issue-number-if-any]