Skip to content

Develop #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rogelio-o merged 5 commits into from
Dec 30, 2017
Merged

Develop #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4616e07
Added npm badge version.
rogelio-o Dec 27, 2017
ffbf8f9
Removed boundaries types to avoid problems related with a typescript iss
rogelio-o Dec 28, 2017
3af5482
Updated examples.
rogelio-o Dec 28, 2017
d4fb6cb
Updated lambda-framework version.
rogelio-o Dec 30, 2017
3491423
Updated version to 1.1.0.
rogelio-o Dec 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Google Cloud Functions implementation

[![Coverage Status](https://coveralls.io/repos/github/rogelio-o/lambda-framework-gcloud/badge.svg?branch=master)](https://coveralls.io/github/rogelio-o/lambda-framework-gcloud?branch=master) [![Build Status](https://travis-ci.org/rogelio-o/lambda-framework-gcloud.svg?branch=master)](https://travis-ci.org/rogelio-o/lambda-framework-gcloud)
[![Coverage Status](https://coveralls.io/repos/github/rogelio-o/lambda-framework-gcloud/badge.svg?branch=master)](https://coveralls.io/github/rogelio-o/lambda-framework-gcloud?branch=master) [![Build Status](https://travis-ci.org/rogelio-o/lambda-framework-gcloud.svg?branch=master)](https://travis-ci.org/rogelio-o/lambda-framework-gcloud) [![npm version](https://badge.fury.io/js/lambda-framework-gcloud.svg)](https://badge.fury.io/js/lambda-framework-gcloud)

Google Cloud Functions implementation of Lambda Framework.

Expand All @@ -15,18 +15,18 @@ import { GCloudHttpHandler, GCloudEventHandler } from "lambda-framework-gcloud"
const app: IApp = new App();
...
const httpHandler: GCloudHttpHandler = new GCloudHttpHandler(app);
export.httpHandler = httpHandler.handle;
export const httpHandle = httpHandler.handle.bind(httpHandler);

const eventHandler: GCloudEventHandler = new GCloudEventHandler(app);
export.eventHandler = eventHandler.handle;
export const eventHandle = eventHandler.handle.bind(eventHandler);
```

### Using Cloud Storage to retrieve the templates

```typescript
import { App, IApp } from "lambda-framework";
import { App, IApp, ITemplateRenderer } from "lambda-framework";
import { GCloudHttpHandler, GCloudEventHandler, GCloudStorageTemplateLoader } from "lambda-framework-gcloud";
import DustTemplateRenderer from "lambda-framework-dustjs";
import { DustTemplateRenderer } from "lambda-framework-dustjs";

const app: IApp = new App();
...
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "lambda-framework-gcloud",
"version": "1.0.0",
"version": "1.1.0",
"description": "Google Cloud Functions implementation of Lambda Framework",
"main": "dist/src/index.js",
"types": "dist/src/index.d.ts",
Expand Down Expand Up @@ -32,9 +32,7 @@
"license": "MIT",
"devDependencies": {
"@types/chai": "^4.0.4",
"@types/express": "^4.11.0",
"@types/mocha": "^2.2.43",
"@types/node": "^8.0.28",
"@types/sinon": "^2.3.7",
"chai": "^4.1.2",
"coveralls": "^3.0.0",
Expand All @@ -50,7 +48,9 @@
},
"dependencies": {
"@google-cloud/storage": "^1.5.1",
"lambda-framework": "^1.1.0",
"@types/express": "^4.11.0",
"@types/node": "^8.0.28",
"lambda-framework": "^1.1.1",
"node-cache": "^4.1.1"
},
"nyc": {
Expand Down
4 changes: 1 addition & 3 deletions src/lib/GCloudEventHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { IApp, IRawCallback, IRawEvent } from "lambda-framework";
import GCloudTransformer from "./GCloudTransformer";
import IGCloudFunctionsCallback from "./types/IGCloudFunctionsCallback";
import IGCloudFunctionsEvent from "./types/IGCloudFunctionsEvent";

/**
* The class that implements the Cloud Functions handler for events.
Expand All @@ -16,7 +14,7 @@ export default class GCloudEventHandler {
this._transformer = new GCloudTransformer();
}

public handle(event: IGCloudFunctionsEvent, callback: IGCloudFunctionsCallback): void {
public handle(event: any, callback: any): void {
const rawEvent: IRawEvent = this._transformer.transformRawEvent(event);
const rawCallback: IRawCallback = this._transformer.transformRawCallback(callback);

Expand Down
3 changes: 1 addition & 2 deletions src/lib/GCloudHttpHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { Request, Response } from "express";
import { IApp, IRawCallback, IRawEvent } from "lambda-framework";
import GCloudTransformer from "./GCloudTransformer";

Expand All @@ -15,7 +14,7 @@ export default class GCloudHttpHandler {
this._transformer = new GCloudTransformer();
}

public handle(request: Request, response: Response): void {
public handle(request: any, response: any): void {
const rawEvent: IRawEvent = this._transformer.transformHttpRawEvent(request);
const rawCallback: IRawCallback = this._transformer.transformHttpRawCallback(response);

Expand Down