fix: tune iOS VAD thresholds to reduce keyboard noise sensitivity#401
Merged
Conversation
…nerator The generator already uses improved VAD thresholds (0.0025) and format handling, but the test assertions were stale: - silenceThreshold: 0.009 → 0.0025 - speechStartMs: 140.0 → 80.0 - silenceEndMs: 900.0 → 700.0 - minRecordingMs: 300.0 → 250.0 Also unignore iOS/App/App/*.swift so the generated plugin source is tracked by git.
Bump silenceThreshold from 0.0025 to 0.005 and speechStartMs from 80ms to 100ms to better filter out keystroke noise while still catching quiet speech. All test assertions updated to match the new values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tune VAD thresholds to balance quiet-speech detection with keyboard-noise rejection:
silenceThreshold: 0.0025 → 0.005speechStartMs: 80ms → 100msThe 0.0025 threshold was too sensitive — picking up keystrokes and background noise. The previous 0.009 was too high, missing quiet speech. 0.005 is the middle ground.
Also updates test assertions to match the new values.