fix: prose theme overrides for dark mode readability#74
Merged
Conversation
The earlier PR removed prose-invert to fix light mode readability, which also broke dark mode prose text. These explicit overrides map tailwind prose tokens to our custom CSS variables per theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\n\nThe first contrast PR (#73) removed
prose-invertto fix light mode chat text, which inadvertently broke dark mode — prose text is now too faint on dark backgrounds.\n\n## Fix\n\nAdded explicit--tw-prose-*CSS variable overrides for both\[data-theme="light"]and\[data-theme="dark"]that map prose tokens to our theme variables. This gives correct text colors in both modes without needingprose-invert.