Extension case sensitivity fix

[tkrn]

No description provided.

[rogeriotaques]

Hi @tkrn ,

Thank you for your contribution. 👍

What do you think to lower-case the o.accepted as well, when comparing to name.lastIndexOf('.').toLowerCase()? By doing that, we can ensure that accepted extensions are aways in lower-case too.

Can you add it to your code?

if ( o.accepted.toLowerCase().indexOf( file.name.substr( file.name.lastIndexOf('.') ).toLowerCase() ) === -1 )

Cheers,

Roger.

[tkrn]

Will do. Then I'll submit a pull request. Good feedback. Thanks! On Jan 18, 2017, at 3:32 PM, Rog?rio Taques <notifications@github.com<mailto:notifications@github.com>> wrote: @rogeriotaques requested changes on this pull request.

________________________________ In src/droparea.js<#3 (review)>:

@@ -203,7 +203,7 @@

// check if dropped file is allowed if ( o.accepted !== null && typeof o.accepted != 'boolean' ) { - if ( o.accepted.indexOf( file.name.substr( file.name.lastIndexOf('.') ) ) === -1 ) + if ( o.accepted.indexOf( file.name.substr( file.name.lastIndexOf('.') ).toLowerCase() ) === -1 ) Hi @tkrn<https://github.com/tkrn> , Thank you for your contribution. ? What do you think to lower-case the o.accepted as well, when comparing to name.lastIndexOf('.').toLowerCase()? By doing that, we can ensure that accepted extensions are aways in lower-case too. Can you add it to your code? if ( o.accepted.toLowerCase().indexOf( file.name.substr( file.name.lastIndexOf('.') ).toLowerCase() ) === -1 ) Cheers, Roger. - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AESMg-eZKH0R9lpOmd8-m349ZERa7PLCks5rTnbkgaJpZM4LmWTA>.