allow JSEN to be initialized from a type-erased JSEN instance#2
Merged
rogerluan merged 2 commits intorogerluan:masterfrom Feb 9, 2022
Merged
allow JSEN to be initialized from a type-erased JSEN instance#2rogerluan merged 2 commits intorogerluan:masterfrom
rogerluan merged 2 commits intorogerluan:masterfrom
Conversation
rogerluan
approved these changes
Feb 9, 2022
Owner
rogerluan
left a comment
rogerluan
left a comment
There was a problem hiding this comment.
Really nice catch!
Thank you for your contribution @loganmoseley , including updating the tests 🤗
Merging this in! 🚀
rogerluan
changed the title
Owner
|
This has been released in v1.1.2 🚀 |
Contributor
Author
|
You're on the ball, Roger 👍🏼 Thanks for the concise, nice library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
JSEN(from: jsen) -> nil. This allows forJSEN(from: jsen) -> jsen. This is analogous toInt(42) -> int, not-> nil.This allows the initializer to accept a
JSENinstance that's been type-erased. This'll come up if the JSEN value has been passed through some function that erases it toAny. In my case, this came up when I passed my "JSON object"[String: JSEN]into an adaptor function that took[String: Any].Thanks for considering!