fix: error when setting @local outside a locals context#131
Merged
Conversation
Spec for #128 — auto-unsubscribe event handlers registered after storyinit on restart to prevent duplicate accumulation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Callers don't need to import the phase flag; the function is a no-op when not in runtime phase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The default LocalsUpdateContext updater was a silent no-op, causing
{set @var} at passage top level to silently discard values. Now throws
a clear error telling authors that @Locals require a {for}, widget,
{link}, or {button} scope. Also makes {set} render errors visibly
via MacroError instead of silently returning null.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Release preview: merging this PR will publish v0.40.1 (patch bump from v0.40.0) |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{set @var}at passage top level (outside{for}, widgets,{link},{button}) now throws a clear error instead of silently discarding the value{set}renders errors visibly viaMacroErrorinstead of silently returningnullCloses #123
Test plan
shows error when setting @local outside a locals context{set @var}inside{for}loops still works correctly{set $var}and{set _var}at passage top level are unaffected🤖 Generated with Claude Code