fix: support @-target in {computed} for per-iteration values (#140)#142
Merged
fix: support @-target in {computed} for per-iteration values (#140)#142
Conversation
…ned) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…for} (#140) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…140) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Release preview: merging this PR will publish v0.43.2 (patch bump from v0.43.1) |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
types/index.d.tswith ~17 missingStoryAPImembers + compile-time drift-detection test%sigil for reactive variables excluded from persistence, routed through tokenizer, expression engine, store, rendering, and published types{computed}referencing@loop variable inside{for}causes infinite reactive loop #140): MemoizeForIteration/WidgetBodylocal state to prevent infinite reactive loops when{computed}reads@locals{computed}referencing@loop variable inside{for}causes infinite reactive loop #140 reopened): Extend{computed}to accept@vartargets that write to per-iteration local scope viaLocalsUpdateContext, fixing shared values across{for}iterationsTest plan
npx vitest run— 1087 tests passnpx tsc --noEmit— typecheck clean{computed @cls = @item.status == 'ok' ? 'green' : 'red'}inside{for}produces per-iteration values{computed _cls = ...}inside{for}still works (last-write-wins, no hang){computed @cls = ...}outside a local scope logs an error🤖 Generated with Claude Code