docs(readme): clarify MCP shim vs full server tool count (#233 gap 1)#391
Conversation
The README implied the `@agentmemory/mcp` shim exposes "all 51 tools when AGENTMEMORY_TOOLS=all". In reality: - `AGENTMEMORY_TOOLS` is a server-side flag (read by iii-engine), not by the shim — setting it in the shim's MCP `env` block does nothing. - The shim has two modes: proxy (when `AGENTMEMORY_URL` reaches a running agentmemory server, all 51 tools are forwarded) and local fallback (no server reachable → 7 hardcoded tools from `src/mcp/standalone.ts`'s `IMPLEMENTED_TOOLS`). This caused users (Cursor / OpenCode / Gemini CLI) following the README to assume they had misconfigured something when they only saw 7 tools. Two changes: - Codex plugin bullet: replace the misleading `AGENTMEMORY_TOOLS=all` qualifier with an accurate proxy/local mode description. - MCP Server section header: add a callout that explicitly enumerates the 7-tool local fallback set and tells users how to unlock the full 51. Addresses gap rohitg00#1 in rohitg00#233. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@therahul-yo is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated ChangesMCP Shim Documentation Clarification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Addresses gap #1 from #233: users following the Cursor / OpenCode / Gemini CLI setup only see 7 tools and assume they misconfigured something.
The README implied the
@agentmemory/mcpshim exposes "all 51 tools whenAGENTMEMORY_TOOLS=all". In reality:AGENTMEMORY_TOOLSis a server-side flag (read by iii-engine), not by the shim — setting it in the shim's MCPenvblock does nothing.AGENTMEMORY_URLreaches a running agentmemory server → all 51 tools forwarded.src/mcp/standalone.ts(memory_save,memory_recall,memory_smart_search,memory_sessions,memory_export,memory_audit,memory_governance_delete).Changes (README.md only)
AGENTMEMORY_TOOLS=allqualifier with an accurate proxy/local mode description.Verification
IMPLEMENTED_TOOLSinsrc/mcp/standalone.ts:16-23verbatim.Note on scope
#233 documents 6 doc gaps in total. This PR addresses only gap 1 to keep the change focused and easy to review. The other gaps (stdio→HTTP MCP bridge docs,
AGENTMEMORY_URLenv-table entry, end-to-end self-hosted Ollama guide, Windowsenv_filegotcha, npm v11 + onnx-proto workaround) are independent and worth separate PRs.🤖 Generated with Claude Code
Summary by CodeRabbit