fix(hermes): keep plugin hook manifest in sync#488
Conversation
|
@honor2030 is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates the Hermes plugin manifest to declare three previously missing hook handlers (system_prompt_block, prefetch, sync_turn) that are already implemented in the Python module, and adds cross-file consistency tests to validate that manifest declarations match README-advertised hooks and implemented methods. ChangesHermes Hook Manifest and Validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
integrations/hermes/plugin.yaml.Test Plan
npm test -- test/consistency.test.tsfailed with the new manifest/provider parity test before updatingplugin.yaml.npm test→ 91 files / 1008 tests passed.npm run buildgit diff --checkCloses #478
Summary by CodeRabbit
Release Notes
New Features
Tests