revert: drop GH Packages mirror, keep single canonical install path#548
Conversation
Reverting the GH Packages publish from #545. GH Packages is a separate registry from npmjs.com — anyone installing `@rohitg00/agentmemory` from `npm.pkg.github.com` needs to point their registry there and authenticate, which is friction users don't have on the canonical `@agentmemory/agentmemory` install from public npm. The right-sidebar Packages widget on the repo page was the only motivation for the mirror. Acceptable to leave it empty — the single canonical install path is the better DX. - Drop `publish-github-packages` job from `.github/workflows/publish.yml` - Drop `packages: write` perm wording from the workflow comment block - Remove "GitHub Packages mirror" badge from README Manual follow-up (post-merge): delete the already-published `@rohitg00/agentmemory@0.9.20` from GH Packages registry via github.com/users/rohitg00/packages/npm/agentmemory/settings → Delete.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR removes GitHub Packages publishing, tightens workflow permissions by scoping ChangesPublishing Security and Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reverts the GH Packages publish from #545.
Why
GitHub Packages is a separate registry from npmjs.com. Installing
@rohitg00/agentmemoryfromnpm.pkg.github.comrequires the user to point their registry there + authenticate — that's real friction users don't hit on the canonical@agentmemory/agentmemoryinstall from public npm.The right-sidebar Packages widget on the repo page was the only motivation for the mirror. Better DX = single canonical install path. Sidebar widget stays empty; acceptable trade.
Diff
+2 / -54across 2 files.Manual follow-up post-merge
Delete the already-published
@rohitg00/agentmemory@0.9.20from GH Packages so the URL stops resolving:0.9.20Out of scope
Sponsor button surface (FUNDING.yml + #547) stays as-is — that part of #545 is unrelated and working.
Summary by CodeRabbit
Documentation
Chores