Skip to content

Support spaces in file names#322

Merged
jonasbn merged 2 commits intorojopolis:masterfrom
akohout-hai:master
Feb 27, 2026
Merged

Support spaces in file names#322
jonasbn merged 2 commits intorojopolis:masterfrom
akohout-hai:master

Conversation

@akohout-hai
Copy link
Contributor

Currently, spaces in file names as mentioned in the Readme do not work due to word splitting in the entrypoint.
With these changes, the spell checker correctly processes files with spaces.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements support for file names containing spaces in the spellcheck GitHub Action. The changes convert the SOURCES_LIST variable from string concatenation to a bash array, which properly preserves spaces in file paths and prevents word splitting issues that would otherwise cause the action to fail when processing files with spaces in their names.

Changes:

  • Convert SOURCES_LIST from string to bash array to handle spaces in file names
  • Update array append operations to use proper bash array syntax with quoted elements
  • Replace string emptiness checks with array length checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jonasbn jonasbn added the enhancement New feature or request label Feb 24, 2026
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved

@akohout-hai thanks for the contribution and assistance. I will ship the release over the weekend, if not earlier.

@jonasbn jonasbn merged commit 296bdcd into rojopolis:master Feb 27, 2026
@jonasbn jonasbn added this to the 0.59.0 milestone Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants