Support spaces in file names#322
Merged
jonasbn merged 2 commits intorojopolis:masterfrom Feb 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements support for file names containing spaces in the spellcheck GitHub Action. The changes convert the SOURCES_LIST variable from string concatenation to a bash array, which properly preserves spaces in file paths and prevents word splitting issues that would otherwise cause the action to fail when processing files with spaces in their names.
Changes:
- Convert
SOURCES_LISTfrom string to bash array to handle spaces in file names - Update array append operations to use proper bash array syntax with quoted elements
- Replace string emptiness checks with array length checks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jonasbn
approved these changes
Feb 27, 2026
Collaborator
jonasbn
left a comment
There was a problem hiding this comment.
This is approved
@akohout-hai thanks for the contribution and assistance. I will ship the release over the weekend, if not earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, spaces in file names as mentioned in the Readme do not work due to word splitting in the entrypoint.
With these changes, the spell checker correctly processes files with spaces.