[Parquet][C++] Add experimental VECTOR repetition level for Arrow FixedSizeList#50
Draft
rok wants to merge 6 commits into
Draft
[Parquet][C++] Add experimental VECTOR repetition level for Arrow FixedSizeList#50rok wants to merge 6 commits into
rok wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prototypes a new experimental Parquet repetition type, VECTOR, mainly for Arrow's
FixedSizeList<T, N>as proposed in Option B here.Today this is written through Parquet LIST, which means we pay repetition/definition-level costs for an inner shape that is already fixed. VECTOR stores the fixed length in the Parquet schema as
vector_lengthand avoids the inner repetition level.Writing
FixedSizeList<T, N>as VECTOR is opt-in viaArrowWriterProperties::Builder::enable_experimental_vector_encoding()defaulting to LIST otherwise.Implemented in this prototype
FixedSizeList<struct<x: float, y: int32>, N>Deferred for now:
Compatibility
We expect non-VECTOR-aware readers to fail when encountering VECTOR repetition level.
Benchmark snapshot
All with
FixedSizeList<float, {80,768,10k,100k}>.Numbers below are from a local debug build, so directional only.
Non-nullable vector
Nullable vector