feat: add optional FRR collector wrapper#18
Merged
Conversation
Expose FRRouting metrics through the upstream frr_exporter library so FRR support can track upstream collectors without reimplementing protocol scraping locally. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Align the container build with the new Go toolchain requirement and drop runtime privileges so the documented Docker path stays reproducible and safer by default. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Describe the FRR wrapper, its upstream-backed toggles, and the Go 1.25 requirement so operators can enable it without reverse-engineering the new configuration. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Surface upstream frr_exporter releases as reviewable pull requests so dependency updates stay visible and easy to validate with existing CI. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/tynany/frr_exporterrpki,vrrp, andpimWhy
This restores FRRouting metrics without reimplementing FRR scraping logic locally, while keeping the integration aligned with the repo’s current optional-collector pattern and making upstream updates easier to track.
Changes
internal/collector/frr_collector.gocmd/sonic-exporter/main.gobehindFRR_ENABLEDinternal/collector/collector_test.goREADME.mdanddocs/architecture.mdDockerfilefor Go 1.25 and non-root runtime.github/dependabot.ymlfor weekly Go module updatesValidation
go test ./...go build ./...docker build .Notes
FRR_ENABLED=falsefrr_exporter v1.11.0requires Go 1.25frr_namespaceRPKIsupport requires FRR built with--enable-rpki