Add computed property names (compile-time support only)#1658
Merged
TwitchBronBron merged 9 commits intomasterfrom Mar 24, 2026
Merged
Add computed property names (compile-time support only)#1658TwitchBronBron merged 9 commits intomasterfrom
TwitchBronBron merged 9 commits intomasterfrom
Conversation
TwitchBronBron
changed the title
TwitchBronBron
changed the title
TwitchBronBron
changed the title
TwitchBronBron
changed the title
TwitchBronBron
changed the title
src/DiagnosticMessages.ts
Outdated
Comment on lines
+422
to
+426
| expectedRightSquareBracketAfterAAComputedKey: () => ({ | ||
| message: `Expected ']' after associative array computed key expression`, | ||
| code: 1144, | ||
| severity: DiagnosticSeverity.Error | ||
| }), |
Member
There was a problem hiding this comment.
I think a simple expectedToken is probably fine, no need to make a separate diagnostic for essentially the same problem.
Also, let's move these down to the bottom of this file.
TwitchBronBron
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.