First Validation performance improvements #1729
Open
markwpearce wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v1, the first run still went through incremental-style dependency analysis (figuring out changed symbols, affected files, and impacted scopes).
In this branch, first validation explicitly assumes everything should be validated, which removes a lot of expensive bookkeeping on cold start.
What is different from v1 for first validation
Before (v1)
Now (this branch)
Why this improves performance
The first validation run has no meaningful incremental baseline, so trying to compute precise impact sets is mostly overhead.
By switching initial validation to a full-pass strategy, we avoid dependency graph churn and repeated scope/file impact calculations, while preserving incremental behavior for subsequent validations.
Additional branch changes (non-first-validation)
Behavior and risk notes
Metrics (Example App)
Before
After
Roughly, a 15-20% improvement on first validation time.