DO NOT MERGE: test security-audit-required gate (release branch)#23
Draft
chrisdp wants to merge 2 commits into
Draft
DO NOT MERGE: test security-audit-required gate (release branch)#23chrisdp wants to merge 2 commits into
chrisdp wants to merge 2 commits into
Conversation
Deliberate revert to verify the security-audit-required gate behaves correctly on non-release PRs. Do not merge.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Counterpart to #22. Verifies the
security-audit-requiredgate blocks a release-branch PR when the audit fails.Same deliberate revert: removes the
serialize-javascriptoverride to surface 2 high-severity advisories frommocha's transitiveserialize-javascript.Expected behavior
Security Audit / audit→ ❌Security Audit / security-audit-required→ ❌ (head isrelease/*, so the gate propagates the audit result)If both checks fail and the merge button is disabled, the gate works. Close this PR without merging.