Drop stale suspend/runtime-error events when debugger is no longer paused#356
Merged
Merged
Conversation
…used DebugProtocolAdapter.emit defers dispatch via setTimeout(0). If isStopped flips back to false between queue and fire (e.g. auto-continue on entry breakpoint, rapid step), the suspend listener in BrightScriptDebugSession called setupSuspendedState -> getThreads, which threw "Cannot get threads: debugger is not paused" as an unhandled rejection. Re-check isAtDebuggerPrompt inside the deferred dispatch and drop the event if the debugger has already resumed. Fixes rokucommunity/vscode-brightscript-language#798
TwitchBronBron
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DebugProtocolAdapter.emitdefers every event withsetTimeout(0). When'suspend'is queued while paused,isStoppedcan flip back tofalsebefore the timer fires (auto-continue on entry breakpoint, rapid step, etc.). The deferred suspend listener inBrightScriptDebugSessionthen callssetupSuspendedState → getThreads, which throwsCannot get threads: debugger is not pausedas an unhandled rejection.Re-check
isAtDebuggerPromptinside the deferred dispatch and drop the event if the debugger has already resumed. Same guard applies to'runtime-error', which routes through the same handler path.Fixes rokucommunity/vscode-brightscript-language#798