Defer initializeProfiling until after InitializedEvent#362
Merged
Conversation
PR #328 moved `initializeProfiling()` ahead of `sendResponse(response)`, which caused `ProfilingEnabledEvent` to be delivered to the extension before VS Code fired `onDidStartDebugSession`. The extension's session-start handler then cleared `brightscript.tracingEnabled`, hiding the profiling toolbar buttons. Move the call to the end of `launchRequest` (after `InitializedEvent`) so the session-start cleanup runs first and the enable event takes effect.
TwitchBronBron
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #328 moved
initializeProfiling()ahead ofsendResponse(response). That causedProfilingEnabledEventto reach the extension before VS Code firedonDidStartDebugSession. The extension's session-start handler then clearedbrightscript.tracingEnabled, hiding the profiling toolbar buttons for the rest of the session.Move the call to the end of
launchRequest(afterInitializedEvent) so the session-start cleanup runs first and the enable event sticks.