fix: Ignoring prod subdependencies without ropm keyword#44
Merged
TwitchBronBron merged 5 commits intoAug 13, 2021
Merged
Conversation
Contributor
Author
|
@TwitchBronBron I updated PR's description |
…nonropm-prod-subdependencies
Contributor
Author
|
@TwitchBronBron any chance to review my 3 PRs soon? |
Member
|
I had hoped to get to them this weekend, but the whole family is sick right now. I'll try real hard to get to them in the next week or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a prod dependency has another prod dependency that has no "ropm" keyword, ROPM is crashing.
Since NPM v7, the default depth is 1. This change doesn't break on NPM v6 (which has infinity depth by default)