Repoint LabelBase inbound links + backfill SEO#33
Merged
Conversation
Upstream commit 0d16f56 ("fixed label-base file name", May 11) renamed abstract-nodes/labelbase.md to abstract-nodes/label-base.md as a follow-up to PR rokudev#31, switching the page slug from `doc:labelbase` to `doc:label-base`. The rename was a pure file-rename with no inbound link updates, leaving 11 link sites pointing at a slug that no longer exists. This change updates all references to match the new slug: - doc:labelbase -> doc:label-base (with anchors preserved) in label-nodes/index.md, label.md, multi-style-label.md, monospace-label.md - /abstract-nodes/labelbase.md -> /abstract-nodes/label-base.md in release-notes/index.md (three file-path refs)
PR rokudev#31 introduced these pages with empty excerpt and metadata fields, matching the default skeleton Roku uses for new files. Upstream commit b228740 ("seo: backfill metadata.title, metadata.description, excerpt for 221 pages") backfilled SEO for all sibling Label/Dialog reference pages but didn't touch these two since they post-date that bulk pass. Fill them in now to keep the section's SEO surface consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #31 (Restore LabelBase as its own page). Two cleanups:
1. Repoint inbound links after the page rename. Commit
0d16f564("fixed label-base file name") renamedabstract-nodes/labelbase.mdtoabstract-nodes/label-base.mdas a follow-up to #31, changing the page slug fromdoc:labelbasetodoc:label-base. The rename was a pure file-rename and didn't update the inbound link sites that #31 had set todoc:labelbase, leaving 11 sites pointing at a slug that no longer exists.2. Backfill SEO metadata. Both
abstract-nodes/label-base.md(introduced in #31) andlabel-nodes/index.md(rewritten in #31) shipped with emptyexcerptandmetadata.title/metadata.descriptionfields, matching Roku's default skeleton for new files. Upstream commitb2287405backfilled SEO for 221 pages including all the sibling Label/Dialog reference pages, but didn't touch these two since they post-date that bulk pass.What changed
Commit 1 — slug fixes:
doc:labelbase→doc:label-base(anchors preserved) across:docs/REFERENCES/scenegraph/label-nodes/index.md(2 sites)docs/REFERENCES/scenegraph/label-nodes/label.md(3 sites)docs/REFERENCES/scenegraph/label-nodes/multi-style-label.md(2 sites)docs/REFERENCES/scenegraph/label-nodes/monospace-label.md(2 sites)abstract-nodes/labelbase.md→abstract-nodes/label-base.mdin:docs/DEVELOPER/release-notes/index.md(3 sites)Commit 2 — SEO backfill:
abstract-nodes/label-base.md: addedexcerpt,metadata.title,metadata.descriptionlabel-nodes/index.md: same