refactor: replace manual mock with gomock#55
Merged
Conversation
- Added go:generate directive to automatically generate mocks - Replaced manual MockConverter implementation with gomock - Updated tests to use the generated mock from gomock - Added uber-go/mock dependency to go.mod - Generated mock file in pkg/converter/mock/ directory This change improves maintainability by using auto-generated mocks instead of manually maintaining mock implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
pkg/converter/converter.go: go:generate ディレクティブを追加pkg/converter/converter_test.go: gomock を使用するように更新pkg/converter/mock/converter.go: gomock で生成された新しいモックファイルpkg/converter/mock_converter.go: 削除（手動モックファイル）go.mod,go.sum: uber-go/mock 依存関係を追加Test plan
go test ./pkg/converter/...でテストが全て成功することを確認go build ./...でビルドが成功することを確認go mod tidyで依存関係が正しく整理されることを確認