ci: H-1 batch 4 — Ruff SIM + RUF

[rolandpg]

Summary

Adds SIM (flake8-simplify) and RUF (ruff-specific) to the ruff select list. Surfaced 37 findings; 17 auto/unsafe-fixed, 16 manual fixes, plus RUF002/RUF003 ignored globally for stylistic unicode (en-dash – and ×).

Manual fixes

• RUF012 mutable default class attr (4) — annotated ClassVar[...] on EntityExtractor.REGEX_PATTERNS / ENTITY_TYPES / _NAME_STOPWORDS, NoteConstructor.CAUSAL_RELATIONS
• SIM102 nested if (4) — flattened to and-combined in ontology + governance_validator
• SIM105 try-except-pass (2) — contextlib.suppress in llm_providers + lance row delete
• SIM108 if-else → ternary (1) — compact_lance mode dispatch
• SIM103 return negated (1) — vector_retriever variance check
• F401 orphan probe-import (1) — dateparser → importlib.util.find_spec

Why ignore RUF002/RUF003

Codebase consistently uses – (EN DASH) as typographic separator in comments and docstrings, and × in performance docs ("32× improvement"). Stylistic, not bugs.

Test plan

• ruff check src/ clean
• ruff format --check src/ clean
• 87/89 critical tests pass (2 pre-existing env-dependent: test_ingest_relationship, test_intent_classification)
• CI green

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Expands the project’s Ruff lint coverage by enabling SIM (flake8-simplify) and RUF (Ruff-specific) rules, then applies mechanical refactors and small typing fixes across the codebase to make the new rules pass.

Changes:

• Update Ruff configuration to select SIM and RUF, and globally ignore RUF002/RUF003 for intentional Unicode punctuation in comments/docstrings.
• Refactor multiple sites to satisfy SIM* rules (flatten nested ifs, replace try/except/pass with contextlib.suppress, simplify list concatenation patterns).
• Fix typing issues surfaced by Ruff (e.g., optional parameter annotations, ClassVar for mutable class attributes).

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/zettelforge/vector_retriever.py	Simplifies variance check return logic for embeddings (SIM103).
src/zettelforge/vector_memory.py	Collapses chunking if/else into a conditional expression (SIM108).
src/zettelforge/synthesis_generator.py	Corrects tier_filter typing to list[str] | None.
src/zettelforge/sqlite_backend.py	Uses contextlib.suppress during WAL checkpoint and simplifies list building.
src/zettelforge/scripts/compact_lance.py	Simplifies mode dispatch to a conditional expression (SIM108).
src/zettelforge/ontology.py	Flattens nested conditionals in validators and query helpers (SIM102).
src/zettelforge/note_constructor.py	Annotates mutable class attribute with ClassVar (RUF012).
src/zettelforge/memory_store.py	Replaces try/except/pass with contextlib.suppress for best-effort deletes (SIM105).
src/zettelforge/memory_manager.py	Removes unused local (_intent_meta), replaces probe-import with find_spec, updates optional typing.
src/zettelforge/llm_providers/init.py	Replaces try/except ValueError with contextlib.suppress during provider registration (SIM105).
src/zettelforge/knowledge_graph.py	Simplifies list extension pattern for DFS paths.
src/zettelforge/graph_retriever.py	Simplifies list extension pattern for BFS paths.
src/zettelforge/governance_validator.py	Flattens nested if structure (SIM102) and removes no-op branch.
src/zettelforge/entity_indexer.py	Adds ClassVar for mutable class attrs, uses contextlib.suppress for cleanup, minor iteration simplification.
src/zettelforge/demo.py	Removes unused return value binding.
src/zettelforge/config.py	Replaces nested try/except/pass with contextlib.suppress for float parsing (SIM105).
src/zettelforge/init.py	Reorders __all__ entries (no functional change).
pyproject.toml	Enables Ruff SIM + RUF and ignores RUF002/RUF003 globally.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.