This repository was archived by the owner on Jul 23, 2018. It is now read-only.
do check to make sure params[k] contains a value or it will error out on...#30
Merged
sbezboro merged 1 commit intorollbar:masterfrom Jul 30, 2014
calvinalvin:master
Merged
do check to make sure params[k] contains a value or it will error out on...#30sbezboro merged 1 commit intorollbar:masterfrom calvinalvin:master
sbezboro merged 1 commit intorollbar:masterfrom
calvinalvin:master
Conversation
… on .length() check
Contributor
|
Thanks for the PR @calvinalvin! Merged and published as version 0.3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... .length() check
In instances where the param's value is null, the scrubRequstParams() will error out and and rollbar will log an error that says "TypeError: Cannot read property 'length' of null" - while the true error in the application is lost.