This repository was archived by the owner on Jul 23, 2018. It is now read-only.
Log messages with debug package; remove verbose option#74
Merged
coryvirok merged 1 commit intorollbar:masterfrom Mar 8, 2016
tremby:debug-logger
Merged
Log messages with debug package; remove verbose option#74coryvirok merged 1 commit intorollbar:masterfrom tremby:debug-logger
coryvirok merged 1 commit intorollbar:masterfrom
tremby:debug-logger
Conversation
Instead of plain console.log and console.error calls, this patch adds a logger module which provides equivalent log and error functions. These are instances of the debug package, and automatically add a coloured "Rollbar" prefix, and some timing information. These messages are namespaced as Rollbar:log and Rollbar:error, and can be enabled/disabled by the user with the DEBUG environment variable (which can include `Rollbar:*` for all). The `verbose` option is therefore surplus and has been removed.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of plain
console.logandconsole.errorcalls, this patch adds a logger module which provides equivalent log and error functions.These are instances of the widely-used debug package, which automatically adds a coloured "Rollbar" prefix, and some timing information.
These messages are namespaced as Rollbar:log and Rollbar:error, and can be enabled/disabled by the user with the
DEBUGenvironment variable (which can includeRollbar:*for all). Theverboseoption is therefore surplus and has been removed.But note that unless the user has
*in theirDEBUGenvironment variable, the default is now to not log these console messages, which is at odds with with the previous behaviour of always logging the error messages and logging certain other messages based on theverboseoption.