Skip to content

Allow disabling payload logging on non-200 status#487

Merged
danielmorell merged 1 commit intorollbar:masterfrom
PoCTo:log_payload_on_error
Apr 17, 2026
Merged

Allow disabling payload logging on non-200 status#487
danielmorell merged 1 commit intorollbar:masterfrom
PoCTo:log_payload_on_error

Conversation

@PoCTo
Copy link
Copy Markdown
Contributor

@PoCTo PoCTo commented Nov 11, 2025

Description of the change

#486
Added "log_payload_on_error" setting, to have ability to not log payloads even in case of non-200 codes received from the host. This addresses potential security issue of exposing access token in logs, as well as allows to not spam huge payloads locally.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

#486

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

… payload in logs when a non-200 status-code occurs
@PoCTo PoCTo marked this pull request as draft November 11, 2025 18:53
@PoCTo PoCTo marked this pull request as ready for review November 11, 2025 18:56
@danielmorell danielmorell self-assigned this Apr 17, 2026
@danielmorell danielmorell self-requested a review April 17, 2026 12:22
Copy link
Copy Markdown
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Dani for submitting this! I like the update!

@danielmorell danielmorell merged commit 60d3cfd into rollbar:master Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants