Send Person Data

[nathantsoi]

Allow users to send a person data JSONObject by calling setPersonData(JSONObject)

[brianr]

Awesome, thanks! @sbezboro, can you review?

One suggestion: might be nice to have a helper method to the effect of setPersonData(String id, String username = null, String email = null)

[nathantsoi]

Good idea!
On Aug 27, 2013 9:23 PM, "Brian Rue" notifications@github.com wrote:

Awesome, thanks! @sbezboro https://github.com/sbezboro, can you review?

One suggestion: might be nice to have a helper method to the effect of setPersonData(String
id, String username = null, String email = null)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-23390165
.

[sbezboro]

Thanks for the PR! I feel like person data should just be set via mutators and not via the Notifier constructor though. I wanted to keep the constructor/Rollbar.init() as clean as possible as it seems more Java-like to me to set optional configuration settings after the fact, unlike some of our other libraries. Just seems like this opens up scenarios for a lot more overloaded Rollbar.init() variants for new optional settings introduced in the future, which can become unwieldy.

What do you think?

[nathantsoi]

Yep, that sounds good. From a usage perspective might be more practical w/
a setter. I actually don't use the constructor, tried to at first, but
quickly realized the user info isn't available in the extended application
class.

Thought I'd leave it in the pull request if it is useful for others, but
agree the constructor overloading could get out of hand.
On Aug 28, 2013 5:00 PM, "Sergei Bezborodko" notifications@github.com
wrote:

Thanks for the PR! I feel like person data should just be set via mutators
and not via the Notifier constructor though. I wanted to keep the
constructor/Rollbar.init() as clean as possible as it seems more
Java-like to me to set optional configuration settings after the fact,
unlike some of our other libraries. Just seems like this opens up scenarios
for a lot more overloaded Rollbar.init() variants for new optional
settings introduced in the future, which can become unwieldy.

What do you think?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-23458208
.