GitHub Issue #225: Allow custom JS addition in RollbarJsHelper#235
Merged
rokob merged 1 commit intorollbar:masterfrom Jul 28, 2017
Merged
GitHub Issue #225: Allow custom JS addition in RollbarJsHelper#235rokob merged 1 commit intorollbar:masterfrom
rokob merged 1 commit intorollbar:masterfrom
Conversation
coryvirok
reviewed
Jul 23, 2017
Contributor
coryvirok
left a comment
coryvirok
left a comment
There was a problem hiding this comment.
LGTM. The only thing I think we should add is an explicit semicolon after the JS tag and before the custom JS.
Contributor
|
I'm going to merge this and then add the explicit semicolon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for injecting custom Javascript through
RollbarJsHelperas per request in issue #225 .Ready for review.