fix: preserve active output tab across compilation errors#36
Merged
Conversation
Lift the active tab state from the Tabs component to OutputContainer via v-model so it persists when the Tabs component unmounts during error display and remounts on successful recompilation. Closes #26
✅ Deploy Preview for rolldown-repl ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tabscomponent toOutputContainerviav-modelso it persists across error/success cyclesProblem
When a compilation error occurs, the
Tabscomponent is unmounted (replaced by the error display). On the next successful compilation,Tabsremounts fresh and defaults totabs[0](index.js), losing the user's tab selection.Fix
Added a
ref<string>()inOutputContainer.vueand bound it to theTabscomponent viav-model. The existing watch inTabs.vuealready handles resetting totabs[0]when the active tab no longer exists in the output.Closes #26