Skip to content

chore(ci): add workflow dispatch to CI action#2169

Merged
hyf0 merged 1 commit intorolldown:mainfrom
inottn:chore/workflow
Sep 13, 2024
Merged

chore(ci): add workflow dispatch to CI action#2169
hyf0 merged 1 commit intorolldown:mainfrom
inottn:chore/workflow

Conversation

@inottn
Copy link
Copy Markdown
Contributor

@inottn inottn commented Sep 5, 2024

Description

Considering the potential inconsistencies between the local and CI, allowing manual triggering of actions will make it more convenient to perform tests in forked repository.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 5, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8240418
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66e3a322e653c8000807aaf4

@hyf0
Copy link
Copy Markdown
Member

hyf0 commented Sep 11, 2024

I'm open to this. Let me try to understand its usage. Where does you need to trigger the CI manually?

@hyf0 hyf0 removed the needs-triage label Sep 11, 2024
@inottn
Copy link
Copy Markdown
Contributor Author

inottn commented Sep 11, 2024

I'm open to this. Let me try to understand its usage. Where does you need to trigger the CI manually?

I sometimes encounter a situation where everything works fine locally, but the CI fails after creating a PR. So, before creating a PR, I merge the corresponding branch into the main branch and push it to trigger the CI, ensuring it passes before creating the PR. This process is quite cumbersome for me, as I need to revert the main branch when syncing upstream code. Therefore, I hope to be able to trigger the CI directly on the forked branch to simplify this workflow.

Copy link
Copy Markdown
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see anything negative, so approved.

@hyf0 hyf0 enabled auto-merge September 13, 2024 02:28
@hyf0 hyf0 added this pull request to the merge queue Sep 13, 2024
Merged via the queue into rolldown:main with commit 906a24b Sep 13, 2024
@inottn inottn deleted the chore/workflow branch September 13, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants