chore: add step to check for minimum node version during setup#2411
Merged
hyf0 merged 2 commits intorolldown:mainfrom Oct 15, 2024
Merged
chore: add step to check for minimum node version during setup#2411hyf0 merged 2 commits intorolldown:mainfrom
hyf0 merged 2 commits intorolldown:mainfrom
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
reviewed
Oct 12, 2024
| @@ -0,0 +1,17 @@ | |||
| const MIN_MAJOR_VERSION = 20 | |||
Member
There was a problem hiding this comment.
Could we create this data by reading from .node-version?
Contributor
Author
|
Are there any blockers to merging this? @hyf0 |
Member
|
Nope. Just forgot to click the auto merge button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using a NodeJS version less than what is in the .node-version file gives a cryptic error, see screenshot below
This PR adds a check if the user has the minimum required version installed
When minimum version is not installed, the script errors out early
When the installed version is above the minimum, the script works as expected