fix: magicString prepend issues by IWANABETHATGUY · Pull Request #8797 · rolldown/rolldown

IWANABETHATGUY · 2026-03-19T13:54:37Z

Summary

Fix prependLeft, prependRight, appendLeft, and appendRight to gracefully handle out-of-bound indices by falling through to intro/outro operations, matching original magic-string behavior
Make prepend_outro and append_intro public in string_wizard so the binding layer can use them for the fallback paths
Enable previously-skipped tests: out-of-bound index tests, isEmpty, and length

Test plan

isEmpty and length tests now pass (previously skipped)
Out-of-bound index tests for appendLeft/appendRight/prependLeft/prependRight now pass
All 128 MagicString tests pass

🤖 Generated with Claude Code

IWANABETHATGUY · 2026-03-19T13:55:00Z

fix: handle negative indices, overlapping ranges, and moved content in MagicString remove #8829
feat: magicString replace with regex #8802
fix: magicString prepend issues #8797 👈 (View in Graphite)
chore: enable 7 previously-skipped MagicString tests #8771
fix: handle reversed slice ranges with moved content #8750
chore: enable all test for reset category in MagicString.test.ts #8749 : 1 other dependent PR (#8753 )
feat: add indentExclusionRanges property to MagicString #8746
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-03-19T16:27:54Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`68c7bf5`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69be506ee883b3000818a426
😎 Deploy Preview	https://deploy-preview-8797--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

IWANABETHATGUY · 2026-03-21T08:01:30Z

Merge activity

Mar 21, 8:01 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 21, 8:01 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Mar 21, 8:05 AM UTC: Merged by the Graphite merge queue.

## Summary - Fix `prependLeft`, `prependRight`, `appendLeft`, and `appendRight` to gracefully handle out-of-bound indices by falling through to intro/outro operations, matching original magic-string behavior - Make `prepend_outro` and `append_intro` public in `string_wizard` so the binding layer can use them for the fallback paths - Enable previously-skipped tests: out-of-bound index tests, `isEmpty`, and `length` ## Test plan - [x] `isEmpty` and `length` tests now pass (previously skipped) - [x] Out-of-bound index tests for `appendLeft`/`appendRight`/`prependLeft`/`prependRight` now pass - [x] All 128 MagicString tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code)

@IWANABETHATGUY

## [1.0.0-rc.11] - 2026-03-23 ### 🚀 Features - magicString replace with regex (#8802) by @IWANABETHATGUY - support `output.sourcemapExcludeSources` option (#8828) by @sapphi-red - support `getIndentString` in MagicString (#8775) by @IWANABETHATGUY - MagicString ignoreList support (#8773) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: remove `pluginName` from `MinimalPluginContext` (#8864) by @sapphi-red - do not report eval?.() as direct eval (#8860) by @IWANABETHATGUY - handle negative indices, overlapping ranges, and moved content in MagicString remove (#8829) by @IWANABETHATGUY - enable arbitrary_precision for serde_json to fix JSON float parsing (#8848) by @elderapo - resolve TypeScript lint errors (#8841) by @Boshen - avoid panic on multi-byte UTF-8 chars in hash placeholder iterator (#8790) by @shulaoda - ci: skip failing vite build watch raw query test (#8840) by @Boshen - ci: use step-level env override to unset VITE_PLUS_CLI_BIN in vite tests (#8838) by @Boshen - ci: move vite tests into CI workflow by @Boshen - ci: unset all VITE_PLUS_* env vars in vite-tests workflow (#8837) by @Boshen - test: skip watch CLI tests on Windows (#8830) by @Boshen - ci: unset VITE_PLUS_CLI_BIN in vite-tests workflow (#8832) by @Boshen - remove redundant bare side-effect imports in entry/facade chunks (#8804) by @h-a-n-a - magicString prepend issues (#8797) by @IWANABETHATGUY - ci: use `vpx` instead of `vp exec` for `pkg-pr-new` (#8827) by @Boshen - set `order` for callable plugins (#8815) by @sapphi-red - handle reversed slice ranges with moved content (#8750) by @IWANABETHATGUY - update emnapi to latest to avoid version mismatch (#8781) by @sapphi-red - external.md on Windows OS (#8780) by @bddjr - align MagicString length/isEmpty with reference magic-string (#8776) by @IWANABETHATGUY ### 🚜 Refactor - extract canonical_ref_resolving_namespace helper (#8836) by @Boshen ### 📚 Documentation - improve external examples for cross-platform correctness (#8786) by @hyf0-agent - update reference to transform function in plugin API documentation (#8778) by @zOadT ### ⚡ Performance - reduce timing of `dervie_entries_aware_chunk_name` (#8847) by @AliceLanniste - bench: remove redundant sourcemap benchmark cases (#8825) by @Boshen - reduce intermediate allocations in `collapse_sourcemaps` (#8821) by @Boshen - enable parallel AST cloning on macOS (#8814) by @Boshen ### 🧪 Testing - watch: use polling watcher and retry for watch error test (#8772) by @sapphi-red ### ⚙️ Miscellaneous Tasks - justfile: skip setup-vite-plus if vp is already installed (#8862) by @Boshen - add expectWarning option to test config (#8861) by @IWANABETHATGUY - justfile: support windows for `just setup` (#8846) by @AliceLanniste - deps: update rust crates (#8852) by @renovate[bot] - deps: update endbug/version-check action to v3 (#8855) by @renovate[bot] - deps: update github-actions (#8853) by @renovate[bot] - deps: update dependency vitepress to v2.0.0-alpha.17 (#8854) by @renovate[bot] - deps: update npm packages (#8851) by @renovate[bot] - bench: use mimalloc as global allocator in bench crate (#8844) by @IWANABETHATGUY - reuse native build artifact in node-validation job (#8826) by @Boshen - speed up CodSpeed benchmark build by disabling LTO (#8824) by @Boshen - remove redundant critcmp benchmark job (#8823) by @Boshen - deps: update rust crate oxc_sourcemap to v6.1.0 (#8785) by @renovate[bot] - node: migrate oxlint and oxfmt to Vite+ (#8813) by @Boshen - revert namespace runners for release build jobs (#8820) by @Boshen - migrate runners to namespace (#8819) by @Boshen - test: relax test utils path assertion to support git worktrees (#8816) by @younggglcy - rename `examples/lazy` to `examples/lazy-compilation` (#8789) by @shulaoda - improve "needs reproduction" wording by @Boshen - deps: update dependency oxlint-tsgolint to v0.17.1 (#8807) by @renovate[bot] - enable 7 previously-skipped MagicString tests (#8771) by @IWANABETHATGUY - upgrade oxc to 0.121.0 (#8784) by @shulaoda - increase Windows dev drive size from 12GB to 20GB (#8779) by @Copilot ### ❤️ New Contributors * @elderapo made their first contribution in [#8848](#8848) * @younggglcy made their first contribution in [#8816](#8816) * @bddjr made their first contribution in [#8780](#8780) * @zOadT made their first contribution in [#8778](#8778) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

@IWANABETHATGUY

## [1.0.0-rc.11] - 2026-03-23 ### 🚀 Features - magicString replace with regex (#8802) by @IWANABETHATGUY - support `output.sourcemapExcludeSources` option (#8828) by @sapphi-red - support `getIndentString` in MagicString (#8775) by @IWANABETHATGUY - MagicString ignoreList support (#8773) by @IWANABETHATGUY ### 🐛 Bug Fixes - forward test filters through vp run (#8870) by @younggglcy - types: remove `pluginName` from `MinimalPluginContext` (#8864) by @sapphi-red - do not report eval?.() as direct eval (#8860) by @IWANABETHATGUY - handle negative indices, overlapping ranges, and moved content in MagicString remove (#8829) by @IWANABETHATGUY - enable arbitrary_precision for serde_json to fix JSON float parsing (#8848) by @elderapo - resolve TypeScript lint errors (#8841) by @Boshen - avoid panic on multi-byte UTF-8 chars in hash placeholder iterator (#8790) by @shulaoda - ci: skip failing vite build watch raw query test (#8840) by @Boshen - ci: use step-level env override to unset VITE_PLUS_CLI_BIN in vite tests (#8838) by @Boshen - ci: move vite tests into CI workflow by @Boshen - ci: unset all VITE_PLUS_* env vars in vite-tests workflow (#8837) by @Boshen - test: skip watch CLI tests on Windows (#8830) by @Boshen - ci: unset VITE_PLUS_CLI_BIN in vite-tests workflow (#8832) by @Boshen - remove redundant bare side-effect imports in entry/facade chunks (#8804) by @h-a-n-a - magicString prepend issues (#8797) by @IWANABETHATGUY - ci: use `vpx` instead of `vp exec` for `pkg-pr-new` (#8827) by @Boshen - set `order` for callable plugins (#8815) by @sapphi-red - handle reversed slice ranges with moved content (#8750) by @IWANABETHATGUY - update emnapi to latest to avoid version mismatch (#8781) by @sapphi-red - external.md on Windows OS (#8780) by @bddjr - align MagicString length/isEmpty with reference magic-string (#8776) by @IWANABETHATGUY ### 🚜 Refactor - extract canonical_ref_resolving_namespace helper (#8836) by @Boshen ### 📚 Documentation - improve external examples for cross-platform correctness (#8786) by @hyf0-agent - update reference to transform function in plugin API documentation (#8778) by @zOadT ### ⚡ Performance - reduce timing of `dervie_entries_aware_chunk_name` (#8847) by @AliceLanniste - bench: remove redundant sourcemap benchmark cases (#8825) by @Boshen - reduce intermediate allocations in `collapse_sourcemaps` (#8821) by @Boshen - enable parallel AST cloning on macOS (#8814) by @Boshen ### 🧪 Testing - watch: use polling watcher and retry for watch error test (#8772) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency @oxc-project/types to v0.122.0 (#8873) by @renovate[bot] - publish-to-npm: use correct vp pm publish (#8871) by @shulaoda - justfile: skip setup-vite-plus if vp is already installed (#8862) by @Boshen - add expectWarning option to test config (#8861) by @IWANABETHATGUY - justfile: support windows for `just setup` (#8846) by @AliceLanniste - deps: update rust crates (#8852) by @renovate[bot] - deps: update endbug/version-check action to v3 (#8855) by @renovate[bot] - deps: update github-actions (#8853) by @renovate[bot] - deps: update dependency vitepress to v2.0.0-alpha.17 (#8854) by @renovate[bot] - deps: update npm packages (#8851) by @renovate[bot] - bench: use mimalloc as global allocator in bench crate (#8844) by @IWANABETHATGUY - reuse native build artifact in node-validation job (#8826) by @Boshen - speed up CodSpeed benchmark build by disabling LTO (#8824) by @Boshen - remove redundant critcmp benchmark job (#8823) by @Boshen - deps: update rust crate oxc_sourcemap to v6.1.0 (#8785) by @renovate[bot] - node: migrate oxlint and oxfmt to Vite+ (#8813) by @Boshen - revert namespace runners for release build jobs (#8820) by @Boshen - migrate runners to namespace (#8819) by @Boshen - test: relax test utils path assertion to support git worktrees (#8816) by @younggglcy - rename `examples/lazy` to `examples/lazy-compilation` (#8789) by @shulaoda - improve "needs reproduction" wording by @Boshen - deps: update dependency oxlint-tsgolint to v0.17.1 (#8807) by @renovate[bot] - enable 7 previously-skipped MagicString tests (#8771) by @IWANABETHATGUY - upgrade oxc to 0.121.0 (#8784) by @shulaoda - increase Windows dev drive size from 12GB to 20GB (#8779) by @Copilot ### ❤️ New Contributors * @younggglcy made their first contribution in [#8870](#8870) * @elderapo made their first contribution in [#8848](#8848) * @bddjr made their first contribution in [#8780](#8780) * @zOadT made their first contribution in [#8778](#8778) --------- Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned IWANABETHATGUY Mar 19, 2026

IWANABETHATGUY mentioned this pull request Mar 19, 2026

fix: handle reversed slice ranges with moved content #8750

Merged

IWANABETHATGUY mentioned this pull request Mar 19, 2026

chore: enable 7 previously-skipped MagicString tests #8771

Merged

2 tasks

graphite-app bot force-pushed the 03-18-chore_enable_more_test_in_magic-string.test.js branch 2 times, most recently from bb4acec to 7156f1a Compare March 19, 2026 14:16

graphite-app bot force-pushed the 03-19-fix_magicstring_prepend_issues branch from 6f068e9 to a6216be Compare March 19, 2026 14:16

IWANABETHATGUY force-pushed the 03-19-fix_magicstring_prepend_issues branch 2 times, most recently from 36b8ca1 to b0cbc20 Compare March 19, 2026 14:51

graphite-app bot changed the base branch from 03-18-chore_enable_more_test_in_magic-string.test.js to graphite-base/8797 March 19, 2026 16:19

IWANABETHATGUY mentioned this pull request Mar 19, 2026

feat: magicString replace with regex #8802

Merged

graphite-app bot force-pushed the graphite-base/8797 branch from 7156f1a to 89f0938 Compare March 19, 2026 16:25

graphite-app bot force-pushed the 03-19-fix_magicstring_prepend_issues branch from b0cbc20 to 6bb20ad Compare March 19, 2026 16:25

graphite-app bot changed the base branch from graphite-base/8797 to main March 19, 2026 16:26

graphite-app bot force-pushed the 03-19-fix_magicstring_prepend_issues branch from 6bb20ad to bba6597 Compare March 19, 2026 16:26

IWANABETHATGUY marked this pull request as ready for review March 21, 2026 07:49

IWANABETHATGUY requested review from hyf0 and shulaoda March 21, 2026 07:52

IWANABETHATGUY force-pushed the 03-19-fix_magicstring_prepend_issues branch from 4569d8b to bba6597 Compare March 21, 2026 07:55

shulaoda approved these changes Mar 21, 2026

View reviewed changes

IWANABETHATGUY added the graphite: merge-when-ready label Mar 21, 2026

graphite-app bot force-pushed the 03-19-fix_magicstring_prepend_issues branch from bba6597 to 68c7bf5 Compare March 21, 2026 08:01

graphite-app bot merged commit 68c7bf5 into main Mar 21, 2026
31 checks passed

graphite-app bot deleted the 03-19-fix_magicstring_prepend_issues branch March 21, 2026 08:05

graphite-app bot removed the graphite: merge-when-ready label Mar 21, 2026

IWANABETHATGUY mentioned this pull request Mar 21, 2026

fix: handle negative indices, overlapping ranges, and moved content in MagicString remove #8829

Merged

github-actions bot mentioned this pull request Mar 23, 2026

release: v1.0.0-rc.11 #8868

Merged

This was referenced Mar 23, 2026

release: v1.0.0-rc.11 #8872

Closed

release: v1.0.0-rc.11 #8876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: magicString prepend issues#8797

fix: magicString prepend issues#8797
graphite-app[bot] merged 1 commit intomainfrom
03-19-fix_magicstring_prepend_issues

IWANABETHATGUY commented Mar 19, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Mar 19, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Mar 21, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

IWANABETHATGUY commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

IWANABETHATGUY commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

IWANABETHATGUY commented Mar 21, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Mar 19, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 19, 2026 •

edited

Loading

netlify bot commented Mar 19, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 21, 2026 •

edited by graphite-app bot

Loading