fix: generate init calls for excluded re-exports in strict execution order by IWANABETHATGUY · Pull Request #8858 · rolldown/rolldown

IWANABETHATGUY · 2026-03-23T01:52:43Z

Closes #8777

Summary

In strict execution order mode, tree-shaken re-export statements (export { x } from / export * from) in ESM-wrapped modules were missing init_*() calls, causing runtime failures with barrel-file patterns (e.g. MUI-style re-exports)
Fixes this in the module finalizer by generating init calls for excluded re-export statements, traversing transitively through non-included barrel modules to find the included importees
Adds two regression tests: issue_8777 (MUI-style barrel re-exports) and exports_chain_shared_barrel_fixpoint (multi-level barrel chain)

IWANABETHATGUY · 2026-03-23T01:52:55Z

fix: generate init calls for excluded re-exports in strict execution order #8858 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-03-31T09:51:00Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`1d25f3d`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69cbbc0d587f6d0008845f82

codspeed-hq · 2026-03-31T10:57:56Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks¹

_{Comparing 03-23-fix_8777-2 (2de09a7) with main (2780deb)²}

10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (dff6aca) during the generation of this report, so 2780deb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

crates/rolldown/src/module_finalizers/mod.rs

IWANABETHATGUY · 2026-03-31T12:16:27Z

Merge activity

Mar 31, 12:16 PM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 31, 12:19 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Mar 31, 12:24 PM UTC: Merged by the Graphite merge queue.

…order (#8858) Closes #8777 ## Summary - In strict execution order mode, tree-shaken re-export statements (`export { x } from` / `export * from`) in ESM-wrapped modules were missing `init_*()` calls, causing runtime failures with barrel-file patterns (e.g. MUI-style re-exports) - Fixes this in the module finalizer by generating init calls for excluded re-export statements, traversing transitively through non-included barrel modules to find the included importees - Adds two regression tests: `issue_8777` (MUI-style barrel re-exports) and `exports_chain_shared_barrel_fixpoint` (multi-level barrel chain)

@sapphi-red

## [1.0.0-rc.13] - 2026-04-01 ### 🚀 Features - add friendly error for unloadable virtual modules (#8955) by @sapphi-red - better error message for unsupported CSS error (#8911) by @sapphi-red ### 🐛 Bug Fixes - prevent chunk merging from leaking entry side effects (#8979) by @IWANABETHATGUY - correct inlining based on module's def format and esModule flag (#8975) by @h-a-n-a - generate init calls for excluded re-exports in strict execution order (#8858) by @IWANABETHATGUY - consistent order for `meta.chunks` in `renderChunk` hook (#8956) by @sapphi-red - subpath imports in glob imports failing to find files (#8885) by @kalvenschraut - browser: bundle binding types in dts output (#8930) by @nyan-left - ci: guard artifact download step in `vite-test-ubuntu` when build is skipped (#8934) by @Copilot - track CJS re-export import records to fix inline const and tree-shaking (#8925) by @h-a-n-a - use ImportKind::Import for common-chunk root computation (#8899) by @IWANABETHATGUY - watch: clear emitted_filenames between rebuilds (#8914) by @IWANABETHATGUY - ci: cache esbuild snapshots to avoid 429 rate limiting (#8921) by @IWANABETHATGUY - always check circular deps in chunk optimizer (#8915) by @IWANABETHATGUY - don't mark calls to reassigned bindings as pure (#8917) by @IWANABETHATGUY - magic-string: throw TypeError for non-string content args (#8905) by @IWANABETHATGUY - magic-string: add split-point validation and overwrite/update options (#8904) by @IWANABETHATGUY ### 🚜 Refactor - pre-compute has_side_effects on ChunkCandidate (#8981) by @IWANABETHATGUY - cleanup and simplify in dynamic_import.rs (#8927) by @ulrichstark - rename came_from_cjs to came_from_commonjs for consistency (#8938) by @IWANABETHATGUY - inline `create_ecma_view` return destructuring and remove redundant binding (#8932) by @shulaoda ### 📚 Documentation - document ensure_lazy_module_initialization_order in code-splitting design doc (#8931) by @IWANABETHATGUY ### 🧪 Testing - add regression test for runtime helper circular dependency (#8958) by @h-a-n-a - enable 8 previously-skipped MagicString remove tests (#8945) by @IWANABETHATGUY - add test for why PureAnnotation is needed in execution order check (#8933) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - add `@emnapi/runtime` and `@emnapi/core` as direct deps of `@rolldown/browser` (#8978) by @Copilot - deps: update dependency vite-plus to v0.1.15 (#8970) by @renovate[bot] - deps: update dependency oxfmt to ^0.43.0 (#8969) by @renovate[bot] - deps: upgrade oxc to 0.123.0 (#8967) by @shulaoda - justfile: deduplicate update-submodule as alias of setup-submodule (#8968) by @shulaoda - deps: update rollup submodule for tests to v4.60.1 (#8965) by @sapphi-red - deps: update test262 submodule for tests (#8966) by @sapphi-red - remove unused `type-check` scripts (#8957) by @sapphi-red - deps: update actions/cache action to v5 (#8953) by @renovate[bot] - deps: update npm packages to v6 (major) (#8954) by @renovate[bot] - deps: update npm packages (#8948) by @renovate[bot] - deps: update rust crates (#8949) by @renovate[bot] - deps: update github-actions (#8947) by @renovate[bot] - deps: update napi (#8943) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.23.0 (#8944) by @renovate[bot] - regenerate testing snapshots (#8928) by @ulrichstark - deps: update dependency rust to v1.94.1 (#8923) by @renovate[bot] ### ❤️ New Contributors * @kalvenschraut made their first contribution in [#8885](#8885) * @nyan-left made their first contribution in [#8930](#8930) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned IWANABETHATGUY Mar 23, 2026

IWANABETHATGUY mentioned this pull request Mar 23, 2026

fix: 8777 #8857

Closed

IWANABETHATGUY changed the base branch from 03-19-fix_8777 to graphite-base/8858 March 31, 2026 09:38

IWANABETHATGUY force-pushed the graphite-base/8858 branch from 3148276 to 2780deb Compare March 31, 2026 09:39

IWANABETHATGUY force-pushed the 03-23-fix_8777-2 branch from e606315 to 0d82f63 Compare March 31, 2026 09:39

IWANABETHATGUY changed the base branch from graphite-base/8858 to main March 31, 2026 09:39

IWANABETHATGUY force-pushed the 03-23-fix_8777-2 branch from 0d82f63 to cc4d733 Compare March 31, 2026 09:50

IWANABETHATGUY force-pushed the 03-23-fix_8777-2 branch 2 times, most recently from 883fd27 to 2de09a7 Compare March 31, 2026 10:44

IWANABETHATGUY changed the title ~~fix: 8777-2~~ fix: generate init calls for excluded re-exports in strict execution order Mar 31, 2026

IWANABETHATGUY marked this pull request as ready for review March 31, 2026 10:50

IWANABETHATGUY requested review from h-a-n-a, hyf0 and shulaoda March 31, 2026 10:50

hyf0 reviewed Mar 31, 2026

View reviewed changes

crates/rolldown/src/module_finalizers/mod.rs Outdated Show resolved Hide resolved

hyf0 approved these changes Mar 31, 2026

View reviewed changes

IWANABETHATGUY force-pushed the 03-23-fix_8777-2 branch from 2de09a7 to 97904ea Compare March 31, 2026 12:13

IWANABETHATGUY added ai-bot graphite: merge-when-ready and removed ai-bot labels Mar 31, 2026

graphite-app bot force-pushed the 03-23-fix_8777-2 branch from 8172ad5 to 1d25f3d Compare March 31, 2026 12:20

graphite-app bot removed the graphite: merge-when-ready label Mar 31, 2026

graphite-app bot merged commit 1d25f3d into main Mar 31, 2026
30 of 31 checks passed

graphite-app bot deleted the 03-23-fix_8777-2 branch March 31, 2026 12:24

github-actions bot mentioned this pull request Apr 1, 2026

release: v1.0.0-rc.13 #8971

Open

github-actions bot mentioned this pull request Apr 1, 2026

release: v1.0.0-rc.13 #8984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: generate init calls for excluded re-exports in strict execution order#8858

fix: generate init calls for excluded re-exports in strict execution order#8858
graphite-app[bot] merged 1 commit intomainfrom
03-23-fix_8777-2

IWANABETHATGUY commented Mar 23, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Mar 23, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 31, 2026

Uh oh!

Uh oh!

IWANABETHATGUY commented Mar 31, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

IWANABETHATGUY commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

IWANABETHATGUY commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

codspeed-hq bot commented Mar 31, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

IWANABETHATGUY commented Mar 31, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Mar 23, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 23, 2026 •

edited

Loading

netlify bot commented Mar 31, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 31, 2026 •

edited by graphite-app bot

Loading