fix(rolldown_plugin_vite_import_glob): normalize resolved alias path to prevent double slashes

[shulaoda]

Related to vitejs/vite#22124, I will add a test case in vite side.

[netlify]

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	d81fa11
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69d6120cafba1400086c1532

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks¹

---

_{Comparing 04-08-fix_rolldown_plugin_vite_import_glob_normalize_resolved_alias_path_to_prevent_double_slashes (d81fa11) with main (5f38a1b)}

Footnotes

1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[sapphi-red]

Vite v7 code:
https://github.com/vitejs/vite/blob/cc383e07b66d4c5a9768fcb570e0af812cb8d999/packages/vite/src/node/plugins/importMetaGlob.ts#L662-L669
https://github.com/vitejs/vite/blob/cc383e07b66d4c5a9768fcb570e0af812cb8d999/packages/vite/src/node/plugins/resolve.ts#L212-L219

v8 code:

rolldown/crates/rolldown_plugin_vite_resolve/src/vite_resolve_plugin.rs

Lines 260 to 269 in 56d4f66

	if args.specifier.starts_with('#')
	&& let Some(resolved_imports) =
	(self.resolve_subpath_imports)(&id, args.importer, args.kind == ImportKind::Require, scan)
	.await?
	{
	id = Cow::Owned(resolved_imports);
	if args
	.custom
	.get(&rolldown_plugin_utils::constants::ViteImportGlob)
	.is_some_and(|v| v.is_sub_imports_pattern())

https://github.com/vitejs/vite/blob/94fd9e7fe1a7d7970ba5e154d588f88318a72302/packages/vite/src/node/plugins/resolve.ts#L354-L360

[shulaoda]

Is this just an explanation of the code, or do I need to make further changes?

[sapphi-red]

It was for me to understand why this change is needed. Would you elaborate why this change is the way to fix vitejs/vite#22124 (#9032 (comment))?

[shulaoda]

It was for me to understand why this change is needed. Would you elaborate why this change is the way to fix vitejs/vite#22124 (#9032 (comment))?

This is because the normalization only targets subpath imports, and it doesn’t fix alias imports. I suspect it might be an issue with the alias plugin, although I’ve aligned the behavior with Vite’s JS import glob implementation.

[shulaoda]

There is a normalizePath here that fixes the issue where alias returns a non-standard path.
https://github.com/vitejs/vite/blob/cc383e07b66d4c5a9768fcb570e0af812cb8d999/packages/vite/src/node/plugins/importMetaGlob.ts#L662

[sapphi-red]

Ah, I see. I overlooked that normalizePath outside.

[sapphi-red]

I'm not sure why this would fix vitejs/vite#22124. Isn't it already normalized at

rolldown/crates/rolldown_plugin_vite_resolve/src/vite_resolve_plugin.rs

Line 276 in 56d4f66

let path = joined.normalize();

?
This .normalize call is aligned with https://github.com/vitejs/vite/blob/cc383e07b66d4c5a9768fcb570e0af812cb8d999/packages/vite/src/node/plugins/resolve.ts#L212-L219