Skip to content

Conversation

@zyyv
Copy link
Contributor

@zyyv zyyv commented Dec 22, 2025

Copilot AI review requested due to automatic review settings December 22, 2025 08:31
@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for tsdown ready!

Name Link
🔨 Latest commit 13cb101
🔍 Latest deploy log https://app.netlify.com/projects/tsdown/deploys/694907ac2d7f3f00082e6d36
😎 Deploy Preview https://deploy-preview-665--tsdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 22, 2025

Open in StackBlitz

npm i https://pkg.pr.new/tsdown@665
npm i https://pkg.pr.new/create-tsdown@665
npm i https://pkg.pr.new/tsdown-migrate@665

commit: 13cb101

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an ignoreRules configuration option to the ATTW (Are The Types Wrong) feature, allowing users to selectively filter out specific problem types when checking package type correctness. The implementation maps ProblemKind enum values to their corresponding CLI flag names and validates user input against allowed values.

  • Added problemFlags constant mapping ProblemKind types to string identifiers
  • Extended AttwOptions interface with ignoreRules option accepting an array of problem flag strings
  • Implemented validation and filtering logic to exclude specified problem types from the check results

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

zyyv and others added 4 commits December 22, 2025 16:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sxzz sxzz merged commit 450b069 into rolldown:main Dec 22, 2025
16 checks passed
@zyyv zyyv deleted the attw/ignorerules branch December 23, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants