fix(css): use aliased exports for CSS module keys#840
Merged
sxzz merged 6 commits intorolldown:mainfrom Mar 25, 2026
Merged
Conversation
…ectly in CSS modules add a check for JavaScript reserved words to avoid using reserved words as named exports when exporting CSS modules
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
sxzz
reviewed
Mar 19, 2026
sxzz
requested changes
Mar 21, 2026
tests/css.test.ts
Outdated
Comment on lines
+1667
to
+1668
| const js = await readFile(`${outputDir}/index.mjs`, 'utf8') | ||
| const css = await readFile(`${outputDir}/style.css`, 'utf8') |
Member
There was a problem hiding this comment.
This is clearly AI vibe-coded. Please be honest and check the checkbox on the PR template accordingly.
Contributor
Author
There was a problem hiding this comment.
I am very sure that I did not use it, the only PR I used has been marked
Contributor
Author
There was a problem hiding this comment.
I didn't refer to the original CSS for testing. test.ts, I also have tests in my own project, and I've done similar unified test entry points, something like this form, so I just migrated it directly.
sxzz
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix the issue where reserved words cannot be exported correctly in CSS modules
add a check for JavaScript reserved words to avoid using reserved words as named exports when exporting CSS modules
reserved words referenced
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#reserved_words
Linked Issues
#839
Additional context