fix(css): don't override internal importer#860
Merged
sxzz merged 1 commit intorolldown:mainfrom Mar 25, 2026
Merged
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the fact, that user specified importers for sass via
preprocessorOptionsoverride the default importer from tsdown.This breaks e.g. importing from
node_modules.For details and reproduction link, see the corresponding issue: #859
Linked Issues
Fixes: #859
Additional context
I fixed the issue by doing the minimal changes, keeping user values overriding all values expect for the special case handling of the
importersarray.If user values overriding the other values would also be considered unintended behaviour, the object spread for the user values could be moved up even further:
if you wanna change it to that, let me know (or feel free to edit yourself, if you prefer).