feat(exports): add bin to publishConfig when devExports is enabled#911
Merged
feat(exports): add bin to publishConfig when devExports is enabled#911
Conversation
When `devExports` is enabled, `exports` puts source paths in the main field and dist paths in `publishConfig.exports`. However, `bin` only wrote dist paths directly without the same dev/publish split. Add a `devExports` parameter to `generateBin`. When true, it returns source paths instead of dist paths. Call `generateBin` twice in `generateExports` (mirroring the `genSubExport` pattern): once with `devExports` for the main `bin` field, and once with `false` for `publishBin`. Write `publishBin` to `publishConfig.bin` in `writeExports`. Closes #908
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
devExportsis enabled,exportscorrectly puts source paths in the main field and dist paths inpublishConfig.exports. However,binonly wrote dist paths directly without the same dev/publish split. This PR adds the same treatment tobin: source paths go to the mainbinfield, and dist paths go topublishConfig.bin.Adds a
devExportsparameter togenerateBinand calls it twice (mirroring thegenSubExportpattern) — once for dev, once for publish.Linked Issues
Closes #908
Additional context
Tests cover all three
binforms (true, string, object) combined withdevExports: true.