feat(config): track transitive config dependencies for watch reload#919
Merged
feat(config): track transitive config dependencies for watch reload#919
Conversation
Replace configFiles: string[] with configDeps: Set<string> and track transitive imports of tsdown.config.ts (and vite config) via import-without-cache's AsyncLocalStorage depsStore and unrun's dependencies output. Watch mode now triggers a full restart when any imported helper of the config changes, not just the config file itself.
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
configFiles: string[]withconfigDeps: Set<string>and track transitive imports oftsdown.config.ts(and optional Vite config) viaimport-without-cache's AsyncLocalStoragedepsStoreandunrun'sdependenciesoutput.Watch mode now triggers a full restart when any imported helper of the config changes, not just the config file itself.
Set.has()also replacesArray.includes()for the reload check.ResolvedConfig.configDepsis exposed as part of the public resolved config shape for downstream consumers.Linked Issues
Additional context