fix(pkg): fix duplicate configuration warning logic#935
Merged
sxzz merged 2 commits intorolldown:mainfrom May 3, 2026
Merged
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the package bundling completion flow when duplicate configuration warnings are emitted and only one of publint/attw has multiple configs for a package.
Changes:
- Adjust duplicate config warning logic to select an available duplicate config (
publintorattw) before logging. - Prevent
TypeError: Cannot read properties of undefined (reading 'logger')inbundleDone()when only one side has duplicates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sxzz
approved these changes
May 3, 2026
sxzz
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bundleDone()crashes withTypeError: Cannot read properties of undefined (reading 'logger')when only one ofpublishConfigs/attwConfigshas length > 1. Falls back to whichever side actually has the duplicate so the warning can be emitted safely.dedupeConfigs(configs, 'publint')collapses to length 1 becausepublint: trueis filtered out and falls through to[filtered[0]].However,
dedupeConfigs(configs, 'attw')keeps length 2 because each entry'sattwis a fresh literal and dedupe is reference-based. TheOR-guarded warning then dereferecespublintConfig[1]and throwsRepro
Linked Issues
Additional context