Merged
Conversation
Use a trie to find relevant callbacks, this cuts about 90% of WS-related CPU. We don't need to go through all the paths when we've already found one.
Contributor
|
Maybe we should split the path into properties and IDs (i.e. split at each '.' and '(') and use those components to index the trie instead of every single letter. This would get rid of unwanted matches when one property is a substring of another. |
Contributor
Author
|
If we do that we should do it back in the backend first, and it is an API change. We'd also have to think about escaping. I'd suggest getting this in for now, as there's big improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a trie to find relevant callbacks, this cuts about 90% of
WS-related CPU.
We don't need to go through all the paths when we've already found one.