Use utf-8 charset for html and other text responses.#249
Merged
frank-weinberg merged 1 commit intodevfrom May 2, 2019
Merged
Conversation
The version of jetty we're using really doesn't make setting this correctly easy. Hack in the charset in the mime entries, overriding what Jetty has by default.
| xbm = image/x-xbitmap | ||
| xht = application/xhtml+xml | ||
| xhtml = application/xhtml+xml | ||
| xls = application/vnd.ms-excel |
Contributor
There was a problem hiding this comment.
Shouldn't we be including .xlsx here as well?
Contributor
Author
There was a problem hiding this comment.
This is only a copy of what upstream has, and I doubt we'll be serving static xlsx files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of jetty we're using really doesn't
make setting this correctly easy. Hack in the charset in
the mime entries, overriding what Jetty has by default.