Allow the Current Ruleset to be changed#367
Conversation
| return getMaximumTime() - getTime(); | ||
| } | ||
| if (prop == Value.MAXIMUM_TIME && getId() == ID_INTERMISSION) { | ||
| long duration = DEFAULT_MAXIMUM_TIME; |
There was a problem hiding this comment.
This means I can no longer override the maximum time for an intermissions from the operator screen, which is often required when the schedule needs moving forward.
|
That updating/deleting rulesets that are in use will affect the in-progress game may not be completely obvious to users. |
|
I have removed the delete button (because it's completely unclear what should be done if the active ruleset is deleted) and added a note that editing will affect the current game for rulesets currently in effect. |
|
That works. A few small issues:
I suspect the last two are existing. |
|
They were existing but sufficiently easy fixes/workarounds. |
brian-brazil
left a comment
brian-brazil
left a comment
There was a problem hiding this comment.
Grand, saves me from fixing them.
| WS.Set("ScoreBoard.Rulesets.Ruleset(" + activeRuleset.Id + ").Rule(" + val.Fullname + ")", value); | ||
| }); | ||
| var newName = tab.find("#name").val(); | ||
| if (newName.trim() === '') { newName = 'Unnamed'; } |
There was a problem hiding this comment.
Elsewhere (colors) we ignore such requests, I think we should do the same here.
| }); | ||
|
|
||
| if (rs.Immutable) { | ||
| tab.find("#name").attr('readonly', true); |
There was a problem hiding this comment.
I think disabled would be a bit clearer
|
Addressed the last comments and fixed an NPE discovered in the process. |
2 participants
This allows e.g. changing intermission duration or en/disabling auto start/stop rules without a reset of the teams.