Skip to content

Show all skater numbers for jammer/pivot selection.#375

Merged
frank-weinberg merged 1 commit intodevfrom
op-number
Oct 30, 2019
Merged

Show all skater numbers for jammer/pivot selection.#375
frank-weinberg merged 1 commit intodevfrom
op-number

Conversation

@brian-brazil
Copy link
Copy Markdown
Contributor

No more dropdowns to get in the way of keyboard shortcuts,
plus it should be faster to use.

I think this works nicely, though this bit of the screen might need a small reorg now. These don't support key controls.

Screenshot_2019-10-23_18-57-46

@frank-weinberg
Copy link
Copy Markdown
Contributor

The selector area is already crowded on this wide screen. On a smaler screeen, this will be too large. How about this layout:

Screenshot_20191026_111531

On half the width this still looks reasonable:

Screenshot_20191026_111243

These don't support key controls.

Why? Not having to take the hand off the keyboard would be very useful.

No more dropdowns to get in the way of keyboard shortcuts,
plus it should be faster to use.
@brian-brazil
Copy link
Copy Markdown
Contributor Author

How about this layout:

That works. If all skater numbers are 4 digit on a widescreen the Box wraps, so that seems fine.

Why? Not having to take the hand off the keyboard would be very useful.

Unlike every other control these are dynamic, so in the best case the semantics would be non-obvious to users (is it tied to a skater? a number? an index in the list?).

@frank-weinberg
Copy link
Copy Markdown
Contributor

in the best case the semantics would be non-obvious to users (is it tied to a skater? a number? an index in the list?).

Since the key assignments are displayed on the buttons, this will be easy enough to figure out. The people who are the audience for this feature will happily learn that. And those that don't want to use the feature don't need to care about it.

What I'd do is tie the key to the skater and drop it if the skater is removed from the roster or the team is replaced. That happens to also be the easiest option to implement.

@brian-brazil
Copy link
Copy Markdown
Contributor Author

Since the key assignments are displayed on the buttons, this will be easy enough to figure out.

Hmm, I wonder how that'd affect wrapping.

What I'd do is tie the key to the skater and drop it if the skater is removed from the roster or the team is replaced.

That'd drop more than you'd expect, such as if a skater's name/number changes (button is deleted and re-created), or a skater is out for 3 jams. This is more complicated than it might seem.

@frank-weinberg
Copy link
Copy Markdown
Contributor

Hmm, I wonder how that'd affect wrapping.

For every given team roster there will be a window size where adding in a key assignment will cause it to wrap. And a slightly smaller one where it will wrap anyways. Since many people are not running the operator screen in fullscreen, speculating about window sizes is moot. We should just make sure that the screen doesn't become unusable on a reasonable range of window sizes.

That'd drop more than you'd expect, such as if a skater's name/number changes (button is deleted and re-created),

I've seen the delete-recreate part. It should be possible to read the key before and reassign after.

or a skater is out for 3 jams.

Out for 3 jams does not remove a skater from the list.

This is more complicated than it might seem.

I'm fine with implementing it myself as long as I don't have to expect a block based on "I don't want that feature".

@brian-brazil
Copy link
Copy Markdown
Contributor Author

I'm fine with implementing it myself as long as I don't have to expect a block based on "I don't want that feature".

That works for me.

@frank-weinberg frank-weinberg merged commit e7b4c10 into dev Oct 30, 2019
@brian-brazil brian-brazil deleted the op-number branch November 21, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants