Show all skater numbers for jammer/pivot selection.#375
Conversation
No more dropdowns to get in the way of keyboard shortcuts, plus it should be faster to use.
14d79e5 to
8bc3713
Compare
That works. If all skater numbers are 4 digit on a widescreen the Box wraps, so that seems fine.
Unlike every other control these are dynamic, so in the best case the semantics would be non-obvious to users (is it tied to a skater? a number? an index in the list?). |
Since the key assignments are displayed on the buttons, this will be easy enough to figure out. The people who are the audience for this feature will happily learn that. And those that don't want to use the feature don't need to care about it. What I'd do is tie the key to the skater and drop it if the skater is removed from the roster or the team is replaced. That happens to also be the easiest option to implement. |
Hmm, I wonder how that'd affect wrapping.
That'd drop more than you'd expect, such as if a skater's name/number changes (button is deleted and re-created), or a skater is out for 3 jams. This is more complicated than it might seem. |
For every given team roster there will be a window size where adding in a key assignment will cause it to wrap. And a slightly smaller one where it will wrap anyways. Since many people are not running the operator screen in fullscreen, speculating about window sizes is moot. We should just make sure that the screen doesn't become unusable on a reasonable range of window sizes.
I've seen the delete-recreate part. It should be possible to read the key before and reassign after.
Out for 3 jams does not remove a skater from the list.
I'm fine with implementing it myself as long as I don't have to expect a block based on "I don't want that feature". |
That works for me. |


No more dropdowns to get in the way of keyboard shortcuts,
plus it should be faster to use.
I think this works nicely, though this bit of the screen might need a small reorg now. These don't support key controls.