fix(commonjs): correctly replaces shorthand "global" property in object#1957
fix(commonjs): correctly replaces shorthand "global" property in object#1957TrickyPi wants to merge 1 commit intorollup:masterfrom
Conversation
|
@CharlieHelps please do a thorough review of this PR to determine if it's ready to merge. Look at the diff, reviews, comments, and referenced issues/docs/links to build a complete understanding. Then respond with a comment that includes a list of MUST fix items that must be fixed before the the PR is merged, and a list of IMPROVEMENTS that shouldn't block the merge but may be quick improvements or things that could be addressed in a follow up PR. The MUST fix items should explain exactly what's wrong and what needs to change to resolve the problem. Both should be numbered lists and the IMPROVEMENTS list should continue counting up from the MUST list. It's OK if there are no IMPROVEMENTS or MUST fix items, you can just omit the lists. |
|
I went through the diff + new fixture/snapshots and checked the PR’s CI status; this looks ready to merge from my side. The change correctly detects an object literal shorthand property IMPROVEMENTS
|
Rollup Plugin Name:
@rollup/plugin-commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves rollup/rollup#6242 (comment)
Description