Sanitize special characters in the current working dir and resolution base dir#63
Sanitize special characters in the current working dir and resolution base dir#63lukastaegert wants to merge 1 commit into
Conversation
|
Hmm, seems I cannot escape characters on Windows with a backslash, go figure. How do I escape characters on Windows!? |
lukastaegert
force-pushed
the
sanitize-cwd
branch
from
d914017 to
b506717
Compare
lukastaegert
force-pushed
the
sanitize-cwd
branch
from
b506717 to
aac7aa8
Compare
| return resolutionBase === false | ||
| ? id | ||
| : resolve( | ||
| sanitizeResolutionBase( |
There was a problem hiding this comment.
myb putting the sanitation after the resolve would work to fix the windows issue
There was a problem hiding this comment.
Good thinking. Problem is we want to sanitize the resolution base but not the id, as it needs to support micromatch patterns. Let's see if I can think of something.
There was a problem hiding this comment.
No, that does not seem to be it. I'm really at a loss here.
There was a problem hiding this comment.
what can the id be? as in what actually gets resolved here
There was a problem hiding this comment.
id is probably badly named. It is any micromatch pattern the user provides.
There was a problem hiding this comment.
E.g. src/**/*.js should be resolved to something like /Users/moi/project/src/**/*.js on a Unix-like system
There was a problem hiding this comment.
ah ok, wasn't sure resolve would deal with wildcards like that
lukastaegert
force-pushed
the
sanitize-cwd
branch
7 times, most recently
from
00bd11b to
16ef1ff
Compare
|
We've moved this repo to https://github.com/rollup/plugins. If anyone would like to take up this PR and resubmit it there, we'd welcome it. |
3 participants
For the moment, this will automatically escape opening and closing parantheses in the current working directory or the
resolveparameter so that they are not interpreted as minimatch patterns.