feat: add resolvedBy field to ResolvedId#4789
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4789 +/- ##
==========================================
- Coverage 99.03% 99.02% -0.02%
==========================================
Files 217 217
Lines 7773 7780 +7
Branches 2158 2161 +3
==========================================
+ Hits 7698 7704 +6
Misses 24 24
- Partials 51 52 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks a lot! Besides the comments I added, it would be nice to also update the documentation. I think this.resolve would be a good place to document it, but it should also be mentioned in resolveId that you can return a resolved field and what the effect is (it changes the return value in this.resolve). Also, we need to update the types in the documentation in at least these two places (not sure if there is another place where the ResolvedId type is used). Thanks for your hard work!
cc1257f to
1e9d774
Compare
1e9d774 to
1ed9fb4
Compare
resolveBy field to ResolvedIdresolvedBy field to ResolvedId
87cbc6e to
1744073
Compare
e27d62a to
aef4368
Compare
|
This PR has been released as part of rollup@3.10.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #4773
Description