Skip to content

apply Halborn comments#12

Merged
valiksinev merged 6 commits into
masterfrom
halborn_assessment
May 6, 2025
Merged

apply Halborn comments#12
valiksinev merged 6 commits into
masterfrom
halborn_assessment

Conversation

@valiksinev
Copy link
Copy Markdown
Contributor

@valiksinev valiksinev commented May 6, 2025

  • HAL-01 - Memory resize does not enforce memory limit boundary - fixed

  • HAL-02 - Memory usage update omitted after buffer resize in set - fixed

  • HAL-03 - Glob re-export from evm_core combined with aliased re-export causes compilation error - fixed

  • HAL-04 - Signextend function allows invalid byte index - fixed

  • HAL-05 - skipped

  • HAL-06 - Missing Cancun opcodes limits compatibility with latest EVM contracts - skipped

Rome- evm doesn't support the transaction type 0x03.
Unknown opcodes are processed by method "other()" of Handler trait:

_ => handle_other(state, opcode, handler),

This trait is impemented in the Rome-evm contract. Handler.other() raises an error if unknown opcode appears:
https://github.com/rome-protocol/rome-evm-private/blob/e127dca5266ad907da3dec8a020299e2bc378bdc/program/src/state/handler.rs#L310

  • HAL-07 - Redundant trace_op! Calls Despite Macro Being Disabled - fixed

  • HAL-08 - Runtime uses fixed configuration and exposes unused alternative profile - fixed

  • HAL-09 - Redundant type conversions - fixed

  • HAL-10 - ExitReason lacks method to identify step limit exhaustion - fixed

  • HAL-11 - Inefficient implementations functions introduce unnecessary complexity - fixed

  • HAL-12 - Lack of consistent documentation across the codebase - fixed

@valiksinev valiksinev merged commit d305bec into master May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants