Fix TensorMap compound assignment operators#155
Merged
romeric merged 1 commit intoromeric:masterfrom Jan 1, 2022
Merged
Conversation
Compound assignment operators such as `+=` are provided where the source is a `TensorMap` and the destination is an `AbstractTensor`. However, since the destination tensor was const-qualified, use of these operators resulted in a compile error.
feltech
added a commit
to feltech/FeltElements
that referenced
this pull request
Dec 17, 2021
* Work around non-`constexpr` `dimension` method. * Only remaining change to upstream Fastor master branch is a fix for `TensorMap` compound assignment operators, which has a PR up at romeric/Fastor#155.
Owner
|
Apologies for late response and thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compound assignment operators such as
+=are provided where the sourceis a
TensorMapand the destination is anAbstractTensor. However,since the destination tensor was const-qualified, use of these operators
resulted in a compile error.