[Bug] Multifiles download not downloading only eating server RAM

[Smurre95]

RomM version
Version of RomM you are using
1.9.1
Describe the bug
A clear and concise description of what the bug is.
When trying to download files that is a multi file selection i don't see any way that the download i starting or even starts creating a zip file. But in my main system i see the docker eating more and more ram. This is for any size of multi file selection. Once i let it be for about 30 min and it had almost all of my 40 GB of server ram allocated to it and still no download completed to my system. Dose not matter the size of the files. Tested with a Gamecube dual disc game so that would be about 3GB in total.

To Reproduce
Steps to reproduce the behavior:
Download more than one file form the same game

Expected behavior
To create a zip and then start the download

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
Firefox
Version 116.0.2 (64-bit)
And
Edge
Version 115.0.1901.200 (Official build) (64-bit

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[gantoine]

I've seen this as well, and AFAICT it's due to python's inability to stream ZIP data. The fact that it keeps eating up memory is weird, but there are a couple solutions around this that I'd like to try.

[Smurre95]

So tested this now just to get a picture of it. Here is a 4 GB game using 10 GB RAM to zip. The work around I have right now is to pre zip all the correct files as one. so that it dose not get detected as multifile but as a zip. Any way just wanted to bring some light to this

[zurdi15]

Thank you for pointing it out. I never tried with something bigger than 1GB and didn't noticed.

[Smurre95]

Tested and working flawlessly on my system. OFC i was dum and tride it on Firefox at first but then went to edge and it downloaded the compresed file :D

[zurdi15]

Right now the downloader should be very much consistent thanks to @gantoine!

[gantoine]

@Smurre95 Are you using the latest version of master to test it (like building you own image)? If so, can you try downloading multiple multi-file games at the same time, and let me know how it behaves?

[zurdi15]

I tested it and it works so smooth, but would be nice if @Smurre95 could test it.

[Smurre95]

ah, I run the dev-latest docker image and that works with out any issues
Also downloading two seems to work